Skip to content

Refactor ProjectiveArithmetic trait#179

Merged
tarcieri merged 1 commit into
masterfrom
refactor-projective-arithmetic
Sep 11, 2020
Merged

Refactor ProjectiveArithmetic trait#179
tarcieri merged 1 commit into
masterfrom
refactor-projective-arithmetic

Conversation

@tarcieri

Copy link
Copy Markdown
Member

Accompanying changes for RustCrypto/traits#300.

@tarcieri tarcieri force-pushed the refactor-projective-arithmetic branch from 983b237 to 8d51e2a Compare September 11, 2020 05:00
@codecov-commenter

codecov-commenter commented Sep 11, 2020

Copy link
Copy Markdown

Codecov Report

Merging #179 into master will increase coverage by 0.14%.
The diff coverage is 80.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   58.39%   58.53%   +0.14%     
==========================================
  Files          25       25              
  Lines        3778     3765      -13     
==========================================
- Hits         2206     2204       -2     
+ Misses       1572     1561      -11     
Impacted Files Coverage Δ
k256/src/arithmetic.rs 100.00% <ø> (ø)
k256/src/arithmetic/field/field_10x26.rs 0.00% <ø> (ø)
k256/src/arithmetic/field/field_5x52.rs 0.00% <ø> (ø)
k256/src/arithmetic/scalar/scalar_4x64.rs 0.00% <ø> (ø)
k256/src/arithmetic/scalar/scalar_8x32.rs 91.70% <ø> (ø)
k256/src/ecdsa/sign.rs 31.48% <0.00%> (+0.57%) ⬆️
p256/src/arithmetic.rs 100.00% <ø> (ø)
k256/src/arithmetic/scalar.rs 78.62% <50.00%> (+1.84%) ⬆️
k256/src/ecdsa/recoverable.rs 58.66% <50.00%> (-3.68%) ⬇️
p256/src/arithmetic/scalar.rs 78.77% <76.19%> (+1.36%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b564b...0043a02. Read the comment docs.

@tarcieri tarcieri force-pushed the refactor-projective-arithmetic branch from 8d51e2a to 767e939 Compare September 11, 2020 05:02
@tarcieri tarcieri force-pushed the refactor-projective-arithmetic branch 2 times, most recently from 6a85d0c to 64dbe4b Compare September 11, 2020 15:20
@tarcieri tarcieri force-pushed the refactor-projective-arithmetic branch from 64dbe4b to 0043a02 Compare September 11, 2020 15:23
@tarcieri tarcieri changed the title [WIP] Refactor ProjectiveArithmetic trait Refactor ProjectiveArithmetic trait Sep 11, 2020
@tarcieri tarcieri marked this pull request as ready for review September 11, 2020 15:26
@tarcieri tarcieri merged commit 31bb6ac into master Sep 11, 2020
@tarcieri tarcieri deleted the refactor-projective-arithmetic branch September 11, 2020 15:27
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants