elliptic-curve: refactor ProjectiveArithmetic trait#300
Merged
Conversation
9c60977 to
47a5cc1
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
47a5cc1 to
d750f17
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
d750f17 to
9fa2903
Compare
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
Member
Author
|
Marking this as ready for review. This was a pretty painful PR that introduced some ugly trait bounds, but I was able to remove several superfluous traits from the I've gone ahead and opened corresponding draft PRs that integrate these changes into downstream crates:
I think this PR is a decent intermediate step towards an
Regarding the ugly trait bounds, I opened one issue on |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
Renames the `Arithmetic` trait to `ProjectiveArithmetic` and changes it to have only a single associated type: `ProjectivePoint`. Adds `AffinePoint<C>` and `Scalar<C>` type aliases which are able to look up the corresponding associated type chain (along with `ProjectivePoint<C>` for consistency, although this is available as `<C as ProjectiveArithmetic>::ProjectivePoint`).
9fa2903 to
890e055
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 11, 2020
Accompanying changes for RustCrypto/traits#300.
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Bumps [crypto-bigint](https://github.com/RustCrypto/crypto-bigint) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/RustCrypto/crypto-bigint/releases) - [Changelog](https://github.com/RustCrypto/crypto-bigint/blob/master/CHANGELOG.md) - [Commits](RustCrypto/crypto-bigint@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: crypto-bigint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
Accompanying changes for RustCrypto/traits#300.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
Arithmetictrait toProjectiveArithmeticand changes it to have only a single associated type:ProjectivePoint.Adds
AffinePoint<C>andScalar<C>type aliases which are able to look up the corresponding associated type chain (along withProjectivePoint<C>for consistency, although this is available as<C as ProjectiveArithmetic>::ProjectivePoint).