Skip to content

ecdsa: remove RecoverableSignPrimitive #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Sep 2, 2020
Merged

ecdsa: remove RecoverableSignPrimitive #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions ecdsa/src/hazmat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,45 +43,6 @@ where
) -> Result<Signature<C>, Error>;
}

/// [`SignPrimitive`] for signature implementations that can provide public key
/// recovery implementation.
pub trait RecoverableSignPrimitive<C>
where
C: Curve + Arithmetic,
SignatureSize<C>: ArrayLength<u8>,
{
/// Type for recoverable signatures
type RecoverableSignature: signature::Signature + Into<Signature<C>>;

/// Try to sign the prehashed message.
///
/// Accepts the same arguments as [`SignPrimitive::try_sign_prehashed`]
/// but returns a boolean flag which indicates whether or not the
/// y-coordinate of the computed 𝐑 = 𝑘×𝑮 point is odd, which can be
/// incorporated into recoverable signatures.
fn try_sign_recoverable_prehashed<K: Borrow<C::Scalar> + Invert<Output = C::Scalar>>(
&self,
ephemeral_scalar: &K,
hashed_msg: &C::Scalar,
) -> Result<Self::RecoverableSignature, Error>;
}

impl<C, T> SignPrimitive<C> for T
where
C: Curve + Arithmetic,
T: RecoverableSignPrimitive<C>,
SignatureSize<C>: ArrayLength<u8>,
{
fn try_sign_prehashed<K: Borrow<C::Scalar> + Invert<Output = C::Scalar>>(
&self,
ephemeral_scalar: &K,
hashed_msg: &C::Scalar,
) -> Result<Signature<C>, Error> {
self.try_sign_recoverable_prehashed(ephemeral_scalar, hashed_msg)
.map(Into::into)
}
}

/// Verify the given prehashed message using ECDSA.
///
/// This trait is intended to be implemented on type which can access
Expand Down