ecdsa: remove RecoverableSignPrimitive#146
Merged
Merged
Conversation
This is really a concern of the `k256` crate and isn't helpful to generalize to other curves.
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 59.60% 60.11% +0.50%
==========================================
Files 8 7 -1
Lines 354 351 -3
==========================================
Hits 211 211
+ Misses 143 140 -3 Continue to review full report at Codecov.
|
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 3, 2020
Removes the RecoverableSignPrimitive trait per RustCrypto/signatures#146
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 3, 2020
Removes the RecoverableSignPrimitive trait per RustCrypto/signatures#146
This was referenced Sep 11, 2020
Merged
tarcieri
added a commit
that referenced
this pull request
Sep 27, 2020
This reverts commit a03cda2 (#146) Revives `RecoverableSignPrimitive` since there have been some requests/use cases for it. First, there was interest in supporting such a primitive for `p256`: RustCrypto/elliptic-curves#184 Second, it would be helpful for Ethereum, since it seems implementations often use (HMAC-DRBG-)SHA-256 for RFC6979, but Keccak256 as the message digest function. Exposing this interface would allow for such combinations which aren't possible otherwise.
tarcieri
added a commit
that referenced
this pull request
Sep 27, 2020
This reverts commit a03cda2 (#146) Revives `RecoverableSignPrimitive` since there have been some requests/use cases for it. First, there was interest in supporting such a primitive for `p256`: RustCrypto/elliptic-curves#184 Second, it would be helpful for Ethereum, since it seems implementations often use (HMAC-DRBG-)SHA-256 for RFC6979, but Keccak256 as the message digest function. Exposing this interface would allow for such combinations which aren't possible otherwise.
tarcieri
added a commit
that referenced
this pull request
Sep 27, 2020
This reverts commit a03cda2 (#146) Revives `RecoverableSignPrimitive` since there have been some requests/use cases for it. First, there was interest in supporting such a primitive for `p256`: RustCrypto/elliptic-curves#184 Second, it would be helpful for Ethereum, since it seems implementations often use (HMAC-DRBG-)SHA-256 for RFC6979, but Keccak256 as the message digest function. Exposing this interface would allow for such combinations which aren't possible otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really a concern of the
k256crate and isn't helpful to generalize to other curves.