Revert "ecdsa: remove RecoverableSignPrimitive"#174
Merged
Conversation
This reverts commit a03cda2 (#146) Revives `RecoverableSignPrimitive` since there have been some requests/use cases for it. First, there was interest in supporting such a primitive for `p256`: RustCrypto/elliptic-curves#184 Second, it would be helpful for Ethereum, since it seems implementations often use (HMAC-DRBG-)SHA-256 for RFC6979, but Keccak256 as the message digest function. Exposing this interface would allow for such combinations which aren't possible otherwise.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a03cda2 (#146)
Revives
RecoverableSignPrimitivesince there have been some requests/use cases for it.First, there was interest in supporting such a primitive for
p256:RustCrypto/elliptic-curves#184
Second, it would be helpful for Ethereum, since it seems implementations often use (HMAC-DRBG-)SHA-256 for RFC6979, but Keccak256 as the message digest function. Exposing this interface would allow for such combinations which aren't possible otherwise.