Deadlock on supplementary nodes#36
Merged
Merged
Conversation
dangthaison91
requested changes
Sep 2, 2019
| Pod::Spec.new do |s| | ||
| s.name = 'RxASDataSources' | ||
| s.version = '0.3.4' | ||
| s.version = '0.4.1' |
Collaborator
There was a problem hiding this comment.
Could you please revert pod version or help to combine with PR #35 for version 0.4 that supports Swift 5?
dangthaison91
approved these changes
Sep 2, 2019
Collaborator
dangthaison91
left a comment
There was a problem hiding this comment.
Thanks @foxware00 for your supporting.
|
Thanks a lot for contributing @foxware00! I've invited you to join the Generated by 🚫 dangerJS |
Contributor
Author
No problem. Are you able to make it available via cocoapods |
Collaborator
|
@foxware00 just pushed version |
Contributor
Author
|
@dangthaison91 Thank you for the quick turnaround! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been playing with
configureSupplementaryViewon CollectionNode and it setsASCollectionSectionedDataSource.configureSupplementaryViewBlockNotSetwhich calls through toDispatchQueue.main.syncwhich quite frequently causes dealocks on the main thread. I noticed a discussion in #23 that applied this fix to theconfigureCellBlockNotSetmethod. This change simply prevents the deadlock which applying the same changes asconfigureCellBlockNotSet. I wasn't 100% sure why theNotSetmethods are being called when I haven't configured the datasource to use block method.