fix(postgres-fixture): drop deprecated rules_docker dependency - #3
Closed
ihistand wants to merge 1 commit into
Closed
fix(postgres-fixture): drop deprecated rules_docker dependency#3ihistand wants to merge 1 commit into
ihistand wants to merge 1 commit into
Conversation
…age directly Upstream Dataform removed @io_bazel_rules_docker from WORKSPACE in commit 8be595a (Mar 2024), but the restored Postgres adapter files in tools/postgres/BUILD still loaded `container_image` from it, breaking `bazel build //...`: error loading package 'tools/postgres': Unable to find package for @io_bazel_rules_docker//container:image.bzl: The repository '@io_bazel_rules_docker' could not be resolved Two paths considered: 1. Restore @io_bazel_rules_docker decl in WORKSPACE (~67 lines of deprecated bazel infra to maintain). 2. Refactor the fixture to use docker run directly. Chose (2). Modern Postgres LTS, no deprecated bazel rules, simpler dev flow. PostgresFixture now starts `postgres:15-alpine` via `docker run` on the local daemon — no Bazel image staging needed. Also rename DOCKER_CONTAINER_NAME from "postgres-df-integration-testing" to "postgres-sa-integration-testing" (rename sweep miss). Verified in Docker: ./scripts/docker-bazel build -- //... -//tools/postgres/... → 332 actions, Build completed successfully tools/postgres/... itself still needs `pg` + `pg-query-stream` added to package.json — that's Phase 1 of docs/postgres_reintegration_assessment.md (separate PR).
This was referenced May 27, 2026
Collaborator
Author
|
Superseded: the Postgres reintegration + Dataform→SQLAnvil rename landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream Dataform removed `@io_bazel_rules_docker` from `WORKSPACE` in commit `8be595ac` (Mar 2024), but the restored Postgres adapter files in `tools/postgres/BUILD` (restored in PR predecessor commit `a220e2ed`) still loaded `container_image` from it, breaking `bazel build //...`:
```
error loading package 'tools/postgres': Unable to find package for
@io_bazel_rules_docker//container:image.bzl: The repository
'@io_bazel_rules_docker' could not be resolved
```
Approach
Two paths considered:
@io_bazel_rules_dockerin WORKSPACE — ~67 lines of deprecated Bazel infra to maintain.docker rundirectly. ← chose thisModern Postgres LTS, no deprecated Bazel rules, simpler dev flow.
PostgresFixturenow startspostgres:15-alpineviadocker runon the local daemon — no Bazel image staging needed.Also renamed
DOCKER_CONTAINER_NAMEfrompostgres-df-integration-testing→postgres-sa-integration-testing(rename sweep miss).Verification
./scripts/docker-bazel build -- //... -//tools/postgres/... # → 332 actions, Build completed successfullyOut of scope
tools/postgres/...itself still doesn't build because the restored adapter importspgandpg-query-stream, which aren't inpackage.json. That's Phase 1 ofdocs/postgres_reintegration_assessment.md— separate PR.Stack
Stacked on PR #2 (`fix/node-toolchain-pin`). Merge order: #1 → #2 → this.
Test plan
pg/pg-query-streamdeps)🤖 Generated with Claude Code