feat(protos): add Postgres + Supabase config messages (Phase 3c) - #6
Closed
ihistand wants to merge 1 commit into
Closed
feat(protos): add Postgres + Supabase config messages (Phase 3c)#6ihistand wants to merge 1 commit into
ihistand wants to merge 1 commit into
Conversation
Adds the proto messages that the Postgres-first-class adapter needs,
per docs/postgres_first_class_design.md §3 + §8.2:
Action-level option blocks:
- PostgresOptions — tablespace, fillfactor, unlogged, native
declarative partitioning, btree/gin/gist/hash/
brin indexes, materialized view refresh policy
- SupabaseOptions — Realtime publication, RLS enable, owner role,
pgvector convenience config; nests PostgresOptions
Top-level connection config:
- BigQueryConnection — project, location, default_dataset
- PostgresConnection — host, port, database, user, password, ssl_mode,
default_schema (libpq-style)
- SupabaseConnection — project_ref, service_role_key, default_schema,
optional direct connection_string override
- WarehouseConfig — discriminated union over the three connection
variants via `oneof connection`
This PR is **additive only**. Nothing references these messages yet —
wiring into ActionConfig sub-messages (TableConfig, IncrementalTableConfig,
etc.) and WorkflowSettings happens in subsequent phases:
- Phase 3a PostgresDbAdapter consumes PostgresConnection
- Phase 4 WorkflowSettings gets a `warehouse: WarehouseConfig` field;
CLI dispatches on warehouse.kind
- Phase 5 SupabaseDbAdapter + rlsPolicy/realtimePublication/wrapper/
vectorIndex action types consume SupabaseOptions
Verified:
./scripts/docker-bazel build //protos:ts → success
./scripts/docker-bazel build //... → success (139 targets)
This was referenced May 27, 2026
Collaborator
Author
|
Superseded: the Postgres reintegration + Dataform→SQLAnvil rename landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3c of `adapter/postgres-first-class` per `docs/postgres_first_class_design.md` §3 + §8.2.
Adds the proto messages the Postgres-first-class adapter needs. Additive only — nothing references these yet. Wiring happens in subsequent phases.
Added messages
Action-level option blocks (peers of the existing inlined BigQuery fields)
Top-level connection config (will live under `WorkflowSettings.warehouse` in Phase 4)
Why additive only
Wiring `PostgresOptions` into `ActionConfig.TableConfig` etc. requires choosing field numbers across 4 messages (TableConfig, ViewConfig, IncrementalTableConfig, OperationConfig) and is a separate concern. Same for `WarehouseConfig` → `WorkflowSettings.warehouse`, which collides semantically with the legacy flat `default_project` / `default_dataset` / `default_location` fields and needs careful migration.
The messages exist; consumers come next.
Verification
```bash
./scripts/docker-bazel build //protos:ts # → success
./scripts/docker-bazel build //... # → success (139 targets)
```
Stack
Stacked on PR #5 (`adapter/postgres-relocate`). Merge order: #1 → #2 → #3 → #4 → #5 → this.
Next phases
Test plan
🤖 Generated with Claude Code