Use Third Iron's apiconnector as default node server#13
Closed
karlbecker wants to merge 2 commits intoSarahZum:masterfrom
Closed
Use Third Iron's apiconnector as default node server#13karlbecker wants to merge 2 commits intoSarahZum:masterfrom
karlbecker wants to merge 2 commits intoSarahZum:masterfrom
Conversation
Also changed the endpoints to match what the apiconnector server uses. Simply replace `your_browzine_library_id` and this should be ready to work with the Third Iron API Connector.
karlbecker
commented
Aug 24, 2017
| // Define Angular module and whitelist URL of server with Node.js script | ||
| var app = angular.module('viewCustom', ['angularLoad']) | ||
| .constant('nodeserver', "https://yourserver.edu") | ||
| .constant('nodeserver', "https://apiconnector.thirdiron.com/v1/libraries/your_browzine_library_id") |
Contributor
Author
There was a problem hiding this comment.
I thought I could have nodeserver simply be https://apiconnector.thirdiron.com/v1/libraries/ , and then have another constant - say library_id - be defined later, so that someone integrating this would just need to change what library_id is if they use the apiconnector server.
However, I don't have an instance of Primo to use, so I can't test out how that would work. Even this approach should simplify setup instructions, though.
Thanks!
Contributor
Author
|
Hey @SarahZum - want to close this PR out since we have a fork at https://github.com/thirdiron/primo-browzine that includes this change? Thanks! |
Owner
|
Thanks for the reminder, Karl, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed the endpoints to match what the apiconnector server uses.
Simply replace
your_browzine_library_idand this should be ready to work with the Third Iron API Connector.