Skip to content

Use Third Iron's apiconnector as default node server #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlbecker wants to merge 2 commits into from
Closed

Use Third Iron's apiconnector as default node server #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50279bf
Use Third Iron's apiconnector server as default node server
karlbecker Aug 24, 2017
7514974
Merge branch 'master' into patch-1
karlbecker Sep 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions js/browzine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Define Angular module and whitelist URL of server with Node.js script
var app = angular.module('viewCustom', ['angularLoad'])
.constant('nodeserver', "https://yourserver.edu")
.constant('nodeserver', "https://apiconnector.thirdiron.com/v1/libraries/your_browzine_library_id")
Copy link
Copy Markdown
Contributor Author

@karlbecker karlbecker Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I could have nodeserver simply be https://apiconnector.thirdiron.com/v1/libraries/ , and then have another constant - say library_id - be defined later, so that someone integrating this would just need to change what library_id is if they use the apiconnector server.

However, I don't have an instance of Primo to use, so I can't test out how that would work. Even this approach should simplify setup instructions, though.

Thanks!

.config(['$sceDelegateProvider', 'nodeserver', ($sceDelegateProvider, nodeserver) => {
let urlWhitelist = $sceDelegateProvider.resourceUrlWhitelist();
urlWhitelist.push(`${nodeserver}**`);
Expand All @@ -12,7 +12,7 @@
var vm = this;
if (vm.parentCtrl.result.pnx.addata.doi && vm.parentCtrl.result.pnx.display.type[0] == 'article') {
vm.doi = vm.parentCtrl.result.pnx.addata.doi[0] || '';
var articleURL = nodeserver + "/primo/browzine/articles?DOI=" + vm.doi;
var articleURL = nodeserver + "/articles?DOI=" + vm.doi;
$http.jsonp(articleURL, {jsonpCallbackParam: 'callback'}).then(function(response) {
$scope.article = response.data;
}, function(error){
Expand All @@ -21,7 +21,7 @@
}
if (vm.parentCtrl.result.pnx.addata.issn && vm.parentCtrl.result.pnx.display.type[0] == 'journal') {
vm.issn = vm.parentCtrl.result.pnx.addata.issn[0].replace("-", "") || '';
var journalURL = nodeserver + "/primo/browzine/journals?ISSN=" + vm.issn;
var journalURL = nodeserver + "/journals?ISSN=" + vm.issn;
$http.jsonp(journalURL, {jsonpCallbackParam: 'callback'}).then(function(response) {
$scope.journal = response.data;
}, function(error){
Expand Down Expand Up @@ -51,7 +51,7 @@
var newThumbnail = '';
if (vm.parentCtrl.item.pnx.addata.issn) {
vm.issn = vm.parentCtrl.item.pnx.addata.issn[0].replace("-", "") || '';
var journalURL = nodeserver + "/primo/browzine/journals?ISSN=" + vm.issn;
var journalURL = nodeserver + "/journals?ISSN=" + vm.issn;
$http.jsonp(journalURL, {jsonpCallbackParam: 'callback'}).then(function(response) {
newThumbnail = response.data.data["0"].coverImageUrl;
}, function(error){
Expand Down