-
Notifications
You must be signed in to change notification settings - Fork 1
페르소나별 싱크로율 임계값 연결 + DB 초기화 순서/탈퇴 버그 수정 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| language: "ko-KR" | ||
|
|
||
| reviews: | ||
| profile: "chill" | ||
| request_changes_workflow: false | ||
| high_level_summary: true | ||
| poem: false | ||
| collapse_walkthrough: false | ||
| auto_review: | ||
| enabled: true | ||
| drafts: false | ||
| path_filters: | ||
| - "!**/build/**" | ||
| - "!**/.venv/**" | ||
| - "!**/node_modules/**" | ||
| - "!ai-server/exercise_pb2.py" | ||
| - "!ai-server/exercise_pb2_grpc.py" | ||
| - "!ai-server/app/proto/exercise_pb2.py" | ||
| - "!ai-server/app/proto/exercise_pb2_grpc.py" | ||
| - "!mysql/**" | ||
| path_instructions: | ||
| - path: "backend/**/*.java" | ||
| instructions: > | ||
| Spring Boot 백엔드. 프로덕션 수준으로 리뷰: 트랜잭션 경계, N+1, 인덱스 활용, | ||
| 동시성(낙관적 락 등), 예외 처리 일관성, 입력 검증을 중점적으로 본다. | ||
| - path: "ai-server/**/*.py" | ||
| instructions: > | ||
| FastAPI/AI 서버. 이 프로젝트에서는 변경 면적을 최소화하는 방침이라, 리팩터링이나 | ||
| 스타일 변경보다 실제 동작 변경 여부와 부작용(특히 세션 상태·gRPC 계약)에 집중해서 본다. | ||
| - path: "frontend/**/*.{ts,tsx}" | ||
| instructions: > | ||
| React Native 프론트엔드. API 계약 일치 여부, 에러 처리, 불필요한 리렌더링을 본다. | ||
| - path: "mysql/*.sql" | ||
| instructions: > | ||
| 스키마/시드 데이터. schema.sql과 data.sql의 컬럼 정의가 어긋나지 않는지, | ||
| FK의 ON DELETE 정책이 실제 삭제 흐름과 맞는지 확인한다. | ||
|
|
||
| chat: | ||
| auto_reply: true | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,16 @@ public record ThresholdUpdateDto( | |
| @NotNull | ||
| @DecimalMin(value = "0.0", message = "고급자 임계값은 0 이상이어야 합니다") | ||
| @DecimalMax(value = "100.0", message = "고급자 임계값은 100 이하여야 합니다") | ||
| BigDecimal advanced | ||
| BigDecimal advanced, | ||
|
|
||
| @NotNull | ||
| @DecimalMin(value = "0.0", message = "다이어트 임계값은 0 이상이어야 합니다") | ||
| @DecimalMax(value = "100.0", message = "다이어트 임계값은 100 이하여야 합니다") | ||
| BigDecimal diet, | ||
|
|
||
| @NotNull | ||
| @DecimalMin(value = "0.0", message = "재활 임계값은 0 이상이어야 합니다") | ||
| @DecimalMax(value = "100.0", message = "재활 임계값은 100 이하여야 합니다") | ||
| BigDecimal rehab | ||
|
Comment on lines
+20
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: sed -n '1,160p' backend/src/main/java/com/shadowfit/dto/admin/ThresholdUpdateDto.java
printf '\n---\n'
sed -n '1,140p' backend/src/main/java/com/shadowfit/model/exercise/Exercise.java
printf '\n---\n'
rg -n "DecimalMin|DecimalMax|Digits|scale = 2|diet|rehab|beginner|advanced" backend/src/main/java/com/shadowfit -SRepository: Shadowfit/init Length of output: 8304 ThresholdUpdateDto의 소수 자릿수를 🤖 Prompt for AI AgentsSource: Path instructions |
||
| ) { | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Shadowfit/init
Length of output: 4826
🌐 Web query:
CodeRabbit path_filters path_instructions exclude include order documentation💡 Result:
CodeRabbit provides two distinct path-based configuration mechanisms in the.coderabbit.yaml file: path_filters and path_instructions [1][2]. These settings are used to control which files are reviewed and how they are reviewed [1][3]. Path Filters The path_filters setting determines which files CodeRabbit includes in or excludes from the review process [1][3]. - Mechanism: It uses standard glob patterns to manage the scope of reviews [3]. - Exclusion: Patterns prefixed with an exclamation mark (!) are excluded from review (e.g.,!/dist/) [1][3]. - Inclusion: Patterns without the prefix explicitly include files [1][3]. If explicit inclusion patterns are used, CodeRabbit limits its review scope to only those matching patterns, effectively ignoring everything else [3]. - Purpose: These filters are primarily used to exclude irrelevant files like binaries, lock files, generated code, and assets, ensuring the AI focuses on meaningful code [1][2][3]. Path Instructions The path_instructions setting applies targeted, free-text guidance to specific paths [1][4]. - Mechanism: It maps a glob pattern (path) to specific instructions [1][2]. - Purpose: This allows you to enforce custom rules or provide context-specific guidance based on the location of the file [1][2]. For example, you can require specific security checks for API controllers, enforce testing best practices for a test directory, or ensure clarity in documentation [1][2]. Configuration Order The documentation specifies these as separate fields under the reviews configuration block [1][3]. While CodeRabbit uses a hierarchical configuration system (combining repository YAML, central configuration, and defaults), explicit settings in your local.coderabbit.yaml file take precedence [5]. You can verify your resolved configuration at any time by using the
@coderabbitaiconfiguration command on a pull request [5]. Top Results: [1] https://docs.coderabbit.ai/configuration/path-instructions [2] https://coderabbit.mintlify.app/configuration/path-instructions [3] https://aicodereview.cc/blog/coderabbit-configuration/Citations:
🏁 Script executed:
Repository: Shadowfit/init
Length of output: 19240
mysql/**제외와mysql/*.sql지침이 서로 무력화됩니다.mysql/**가 리뷰 대상에서 빠지면mysql/schema.sql과mysql/data.sql에 적용하려는 지침도 함께 적용되지 않습니다. 스키마/시드까지 검토할 의도라면 제외 범위를mysql/*.cnf같은 비-SQL 파일로 좁히세요.🤖 Prompt for AI Agents