Fix liquid-c integration testing#1310
Merged
Merged
Conversation
It isn't in the gemspec's require_path, so we shouldn't add any dependence on it.
peterzhu2118
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are a couple of changes to liquid-c that are causing failures in this repos test suite, since it tests integration with liquid-c master:
Solution
I've dropped ruby 2.4 support here as well for simplicity.
I've also created a test:integration rake task that is used for running the integration tests with liquid-c. While creating that new test task, I noticed that we strangely include the root directory of the repo in the load path, even though only "lib" is only the require_path in the gemspec, so I removed this root directory from both test tasks.