Add yard tags#1576
Merged
Merged
Conversation
ghost
added
the
jake-olney
force-pushed
the
jake-liquid-schema-update
branch
from
46c44fe to
6567df1
Compare
jake-olney
force-pushed
the
jake-liquid-schema-update
branch
from
3137fc3 to
cdf67cd
Compare
shainaraskas
approved these changes
May 29, 2022
Contributor
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
looks really good! a couple of things to address before you ship
| # @liquid_name join | ||
| # @liquid_summary | ||
| # Combines all the items in an array into a single string, separated by a space. | ||
| # @liquid_syntax array | join |
Contributor
There was a problem hiding this comment.
missing optional param. bet you put this in the spreadsheet. will stop noting them lol
klenotiw
reviewed
May 31, 2022
mllemango
force-pushed
the
jake-liquid-schema-update
branch
from
19b13d8 to
b053938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
As part of the Liquid Reference Redesign, this PR adds yard tags for drops/filters/tags that are part of the Liquid documentation on
shopify.dev.