Drop support for Ruby 2.5 and 2.6#1578
Conversation
andyw8
force-pushed
the
andyw8/drop-support-for-ruby2.5-and-2.6
branch
from
f1d75f2 to
e6c0a2f
Compare
andyw8
force-pushed
the
andyw8/drop-support-for-ruby2.5-and-2.6
branch
from
e6c0a2f to
4ec0b85
Compare
| end | ||
|
|
||
| group :test do | ||
| gem 'rubocop', '~> 1.4', require: false |
There was a problem hiding this comment.
I removed this since rubocop is already a dependency of rubocop-shopify.
macournoyer
left a comment
macournoyer
left a comment
There was a problem hiding this comment.
I see no reasons to keep < 2.7 support around. @dylanahsmith do you know if we're using this anywhere w/ Ruby < 2.7?
| ## 5.4.0 (unreleased) | ||
|
|
||
| ### Breaking Changes | ||
| * Require Ruby >= 2.7 (#1578) [Andy Waite] |
There was a problem hiding this comment.
Arguably this should be a major release (6.0), depending on how strict we're being with semver.
There was a problem hiding this comment.
There is already a "Changed" section with a potentially breaking change, so this should probably be combined with that section.
There was a problem hiding this comment.
I can move it, but I noticed the previous Ruby bump was listed under that section name:
### Breaking Changes
* Require Ruby >= 2.5 (#1131, #1310) [Mike Angell, Dylan Thacker-Smith]
There was a problem hiding this comment.
Yeah, I had called it "Changed" to de-emphasize the fact that it could break applications, since it wasn't clear that it would actually break applications in practice (the name "Changes" would have been more consistent with the other sections though).
I'm fine with calling it "Breaking Changes" and putting it first to further emphasize that this is dropping support for something, although perhaps it could be "Drop support for end-of-life ruby versions (2.5 & 2.6)" to again de-emphasize the scope of the breakage given that support for these versions has already been dropped upstream.
|
@macournoyer it shouldn't be a problem for us. It could affect users of the system version of ruby. |
3 participants
@jake-olney encountered an issue with RuboCop:
#1576
Upgrading rubocop-shopify solves it but it is not compatible with older Rubies.
@macournoyer suggested we should drop these as both are EOL: https://endoflife.date/ruby