This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Fix for "Keep the remote version" deletes files on new development theme#2463
Merged
mgmanzella merged 1 commit intomainfrom Jul 19, 2022
Merged
Fix for "Keep the remote version" deletes files on new development theme#2463mgmanzella merged 1 commit intomainfrom
mgmanzella merged 1 commit intomainfrom
Conversation
f1b28b5 to
ef8ba7f
Compare
karreiro
approved these changes
Jul 18, 2022
Contributor
karreiro
left a comment
There was a problem hiding this comment.
Thank you, @mgmanzella! Elegant PR 🚀
I've left one minor/optional comment to clarify a detail, but the PR looks good and works fine as well 🎩
Thanks!
ef8ba7f to
583a2b6
Compare
ulgut
reviewed
Jul 18, 2022
ulgut
approved these changes
Jul 18, 2022
583a2b6 to
7dc18fd
Compare
0f6f54a to
a49ae9c
Compare
4 tasks
This was referenced Jan 27, 2023
Poitrin
pushed a commit
that referenced
this pull request
Jan 30, 2023
### WHY are these changes introduced? Part of https://github.com/Shopify/internal-cli-foundations/issues/509 Is required by Shopify/cli#1169 Issue #2433 was fixed with #2463. With Shopify/cli#1169, Node CLI needs to pass Ruby CLI a hidden flag to differentiate themes created at runtime. ### WHAT is this pull request doing? Introduces `--overwrite-json` flag that Node CLI can pass to Ruby CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #2433
WHAT is this pull request doing?
@created_at_runtimevariable that gets set to true if development theme is created@created_at_runtime=trueHow to test your changes?
New development themes defaults to local files
In a new terminal
Copy the path printed after
pwdIn another terminal
Confirm local files get uploaded and don't get deleted. Some files do get updated locally though
Existing development theme prompts user for strategy
In the theme directory run
git reset --hardto restore the files. In the shopify-cli directory runshopify-dev theme serve </Path/to/theme/> --theme-editor-syncagain and confirm you're prompted to pick a sync strategyPost-release steps
None
Update checklist