This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Conversation
Poitrin
changed the title
--overwrite-json flag--overwrite-json flag
Poitrin
requested review from
a team,
gonzaloriestra and
matteodepalo
and removed request for
a team
6 tasks
karreiro
approved these changes
Jan 27, 2023
matteodepalo
approved these changes
Jan 30, 2023
6 tasks
Poitrin
pushed a commit
to Shopify/cli
that referenced
this pull request
Feb 6, 2023
…hemes (#1169) ### WHY are these changes introduced? Fixes https://github.com/Shopify/internal-cli-foundations/issues/509 Fixes #1084 Fixes #1263 Requires Shopify/shopify-cli#2724 ### WHAT is this pull request doing? * Generates Development Theme ID and calls Themes API in Node.js CLI. * Depending on the `shopify theme` command: passes ID of generated theme to Ruby CLI for further processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/internal-cli-foundations/issues/509
Is required by Shopify/cli#1169
Issue #2433 was fixed with #2463.
With Shopify/cli#1169, Node CLI needs to pass Ruby CLI a hidden flag to differentiate themes created at runtime.
WHAT is this pull request doing?
Introduces
--overwrite-jsonflag that Node CLI can pass to Ruby CLI.How to test your changes?
lib/shopify_cli/theme/theme.rb, remove the line@created_at_runtime = true, because theme will already have been created by Node CLI.shopify(-dev) theme serve /path/to/theme --theme-editor-syncshopify(-dev) theme serve /path/to/theme --theme-editor-sync --overwrite-jsonPost-release steps
–
Update checklist