Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Delete checksum after file deletion#2706

Merged
Poitrin merged 2 commits intomainfrom
fix-733
Jan 4, 2023
Merged

Delete checksum after file deletion#2706
Poitrin merged 2 commits intomainfrom
fix-733

Conversation

@Poitrin
Copy link
Copy Markdown
Contributor

@Poitrin Poitrin commented Jan 4, 2023

WHY are these changes introduced?

Fixes Shopify/cli#733

Files that get added and uploaded, then deleted (both local and remote), then added again, will not get uploaded again, because checksums are outdated.

WHAT is this pull request doing?

When a file has been successfully deleted (both local and remote), checksum in checksum store is removed, so that the same file can be reuploaded again.

How to test your changes?

  1. In a theme directory, run shopify theme serve
  2. Add a new file, e.g. index.js with content console.log('…') in the assets folder, and verify that it gets uploaded.
  3. Delete the file locally, and verify that it gets deleted remotely too.
  4. Revert the delete, and verify that it gets uploaded again.

Post-release steps

  • New CLI 3.x release

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above (if needed).

@Poitrin Poitrin requested review from a team, isaacroldan and pepicrft and removed request for a team January 4, 2023 10:01
Copy link
Copy Markdown
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Poitrin!

@Poitrin Poitrin merged commit 9c3adb1 into main Jan 4, 2023
@Poitrin Poitrin deleted the fix-733 branch January 4, 2023 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: theme dev doesn't sync files when using Vite with emptyOutDir: true

3 participants