This repository was archived by the owner on Dec 16, 2025. It is now read-only.
✨ Add integration tests for both controllers#79
Merged
Conversation
michal-gubricky
force-pushed
the
feat/add-integration-tests
branch
3 times, most recently
from
February 6, 2024 10:13
dd2aba7 to
7f3e1ef
Compare
michal-gubricky
marked this pull request as draft
February 6, 2024 10:29
michal-gubricky
force-pushed
the
feat/add-integration-tests
branch
2 times, most recently
from
February 8, 2024 07:25
85337e0 to
8a5ace7
Compare
michal-gubricky
marked this pull request as ready for review
February 8, 2024 07:29
michal-gubricky
force-pushed
the
feat/add-integration-tests
branch
2 times, most recently
from
February 8, 2024 08:06
bb464f0 to
6a5b251
Compare
michal-gubricky
requested review from
chess-knight,
janiskemper and
matofeder
February 8, 2024 15:09
chess-knight
reviewed
Feb 8, 2024
chess-knight
reviewed
Feb 9, 2024
Member
|
I will review ones the review of @chess-knight is addressed! Just ping me again okay? |
chess-knight
reviewed
Feb 9, 2024
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
…t.go Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
…t.go Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
…t.go Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/add-integration-tests
branch
from
February 9, 2024 11:30
9428f42 to
1fdffae
Compare
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/add-integration-tests
branch
from
February 9, 2024 14:01
e60348d to
c27e8f4
Compare
Contributor
Author
@janiskemper you can take a look at it now, all comments from @chess-knight were addressed. |
chess-knight
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds integration tests for both CSPO controllers
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #73
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: