This repository was archived by the owner on Dec 16, 2025. It is now read-only.
✨ use local_mode with cspo#88
Merged
Merged
Conversation
kranurag7
requested review from
chess-knight,
janiskemper and
michal-gubricky
February 13, 2024 19:20
chess-knight
left a comment
chess-knight
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR with updated CSO, I left multiple comments/questions.
Can you add also docs, please?
kranurag7
force-pushed
the
syself/local-mode
branch
from
February 15, 2024 15:14
79928ba to
318db25
Compare
janiskemper
marked this pull request as ready for review
February 15, 2024 17:16
kranurag7
force-pushed
the
syself/local-mode
branch
from
February 15, 2024 19:59
318db25 to
f5380d7
Compare
michal-gubricky
approved these changes
Feb 16, 2024
Signed-off-by: kranurag7 <anurag.kumar@syself.com>
kranurag7
force-pushed
the
syself/local-mode
branch
from
February 16, 2024 19:55
f5380d7 to
178bfe5
Compare
This was referenced Feb 22, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds local_mode with cspo.
This also removes helm from cspo image. (Fixes #81)
There are some follow-up task (usage docs) to this which can be added in a separate commit or PR.