Update Operator Docs Introduction#109
Merged
Merged
Conversation
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
maxwolfs
requested review from
chrisschwa,
fdobrovolny,
jschoone and
rholling
November 8, 2023 14:19
fdobrovolny
reviewed
Nov 14, 2023
fdobrovolny
left a comment
fdobrovolny
left a comment
Contributor
There was a problem hiding this comment.
Considering the two TODO is this ready for review?
Member
Author
Well, except for the both TODOs it's ready for review. |
# Conflicts: # docs/index.md
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
jschoone
requested changes
Jan 10, 2024
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
…reignCloudStack/docs into feat/refactor-operator-introduction
fdobrovolny
reviewed
Jan 12, 2024
fdobrovolny
left a comment
fdobrovolny
left a comment
Contributor
There was a problem hiding this comment.
I discussed some minor graphical issues with Max directly:
Here are more suggestions for some minor changes in wording.
Other than that, LGTM.
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
maxwolfs
force-pushed
the
feat/refactor-operator-introduction
branch
from
January 17, 2024 13:34
f7dd985 to
27e697d
Compare
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
jschoone
self-requested a review
February 5, 2024 16:00
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Max Wolfs <mail@maxwolfs.com>
…reignCloudStack/docs into feat/refactor-operator-introduction
maxwolfs
requested review from
berendt,
chess-knight,
fdobrovolny,
matofeder and
scoopex
February 29, 2024 13:37
chess-knight
reviewed
Mar 1, 2024
chess-knight
left a comment
chess-knight
left a comment
Member
There was a problem hiding this comment.
Overall LGTM, just two minor suggestions
chess-knight
reviewed
Mar 1, 2024
chess-knight
left a comment
chess-knight
left a comment
Member
There was a problem hiding this comment.
Please see also #152 - missing k8s-cluster-api-provider docs
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
fdobrovolny
approved these changes
Mar 1, 2024
fdobrovolny
left a comment
fdobrovolny
left a comment
Contributor
There was a problem hiding this comment.
Looked only at changes since my last review, looks perfect 👼
chess-knight
reviewed
Mar 1, 2024
chess-knight
approved these changes
Mar 1, 2024
jschoone
approved these changes
Mar 4, 2024
JuanPTM
pushed a commit
to JuanPTM/docs
that referenced
this pull request
Jun 3, 2024
* remove deprecated parts Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix linkg Signed-off-by: Max Wolfs <mail@maxwolfs.com> * feat: add cluster stacks description Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * refactor components for better reuse with json Signed-off-by: Max Wolfs <mail@maxwolfs.com> * import architecture component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix loading Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add first single components to overview component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Adjust model Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add custom data plugin Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix: typo Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * fix calendar link Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add container registry docs and display it on the overview map (SovereignCloudStack#143) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add monitoring docs and display it on the overview map (SovereignCloudStack#144) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add CSPO docs and display it on the overview map (SovereignCloudStack#149) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * fix component sizing Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add missing k8s-cluster-api-provider doc pages (SovereignCloudStack#152) Signed-off-by: Roman Hros <roman.hros@dnation.cloud> * fix title Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> --------- Signed-off-by: Max Wolfs <mail@maxwolfs.com> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Co-authored-by: Matej Feder <matej.feder@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #103
closes #64
closes #136