Conversation
This comment was marked as resolved.
This comment was marked as resolved.
TimHess
commented
Jan 25, 2024
Member
Author
|
This PR is now (manually) deployed and paired with the mainsite pr preview site |
Member
bart-vmware
reviewed
Feb 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
bart-vmware
requested changes
Feb 7, 2024
Member
bart-vmware
left a comment
There was a problem hiding this comment.
See remarks. Great job on the deployment work, it's nice to be able to test without running the site locally.
bart-vmware
reviewed
Feb 7, 2024
Preview link: https://docs-steeltoe-pr-310.azurewebsites.net
|
bart-vmware
requested changes
Feb 16, 2024
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
Member
Author
The differences are caused by significant interference from docfx here... I can try to fix it now, but I'm not sure how much effort it's worth if we follow up on updating docfx (which I think is something we should do soon) |
This comment was marked as resolved.
This comment was marked as resolved.
Closed
This comment was marked as resolved.
This comment was marked as resolved.
bart-vmware
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





also updates site nav to match mainsite as of SteeltoeOSS/MainSite#141