Skip to content

Don't override "Set" in certificate config providers#1142

Merged
TimHess merged 1 commit into
release/3.2from
allowset_certproviders
Jul 18, 2023
Merged

Don't override "Set" in certificate config providers#1142
TimHess merged 1 commit into
release/3.2from
allowset_certproviders

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Jul 14, 2023

Description

Without this change, the certificate config providers have a compatibility issue with the ConfigurationManager in .NET 6 and .UseCloudHosting (which calls webHostBuilder.UseSetting(WebHostDefaults.ServerUrlsKey, string.Join(";", urls)); and apparently tries to set the value in at least these config providers)

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Component/Configuration Issues related to Configuration providers Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Jul 14, 2023
@TimHess TimHess added this to the 3.2.4 milestone Jul 14, 2023
@TimHess TimHess requested a review from hananiel July 14, 2023 19:59
@TimHess TimHess self-assigned this Jul 14, 2023
@TimHess TimHess changed the title Don't override set in certificate config providers Don't override "Set" in certificate config providers Jul 14, 2023
@TimHess
Copy link
Copy Markdown
Member Author

TimHess commented Jul 14, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TimHess TimHess merged commit 6c9fb5d into release/3.2 Jul 18, 2023
@TimHess TimHess deleted the allowset_certproviders branch July 18, 2023 18:11
@TimHess TimHess mentioned this pull request Dec 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Configuration Issues related to Configuration providers Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants