Bring fixes from 3.2 line to 4.0#1229
Merged
Merged
Conversation
ab6be53 to
824ae1d
Compare
Member
Author
|
/azp run cleanup-code |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Code cleanup failed to reformat and push changes. View details here. |
bart-vmware
requested changes
Dec 11, 2023
Member
|
Looks like |
824ae1d to
252d510
Compare
Member
Author
Thanks, I figured that out this morning from cleanupcode.ps1 |
252d510 to
df6748a
Compare
bart-vmware
requested changes
Dec 11, 2023
Member
bart-vmware
left a comment
There was a problem hiding this comment.
Can you please add a commit to fix this one?
Looks like pr-code-cleanup.yml is broken. To fix it, replace:
--dotnetcoresdk=$(dotnet --version)
with:
--jb --dotnetcoresdk=$(dotnet --version)
* mark certificates Exportable when opening them * confirm certificate is present before removing it, add a test for cert rotation service
b6d4a22 to
c4d0e6f
Compare
bart-vmware
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply fixes from several PRs against 3.2 in to 4.0. commits were applied in this order: #1142, #1170, #1200, #1208, #1219
Fixes #1169
Fixes #1199
Fixes #1178
Fixes #1218
Fixes #1217
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.