Skip to content

Fix service discovery auth issue on ASA-E#1200

Merged
TimHess merged 4 commits into
release/3.2from
x509constructor
Oct 11, 2023
Merged

Fix service discovery auth issue on ASA-E#1200
TimHess merged 4 commits into
release/3.2from
x509constructor

Conversation

@TimHess
Copy link
Copy Markdown
Member

@TimHess TimHess commented Oct 9, 2023 •
edited
Loading

Description

Use the default constructor when creating an x509Certificate from a path on disk

Fix for 3.2 #1199

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Discovery Issues related to Steeltoe Service Discovery Component/Common labels Oct 9, 2023
@TimHess TimHess self-assigned this Oct 9, 2023
hananiel
hananiel reviewed Oct 9, 2023
View reviewed changes
Comment thread src/Common/src/Common.Security/ConfigureCertificateOptions.cs Outdated
@TimHess TimHess requested a review from hananiel October 10, 2023 20:48
@TimHess
Copy link
Copy Markdown
Member Author

TimHess commented Oct 10, 2023 •
edited
Loading

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 10, 2023

Azure Pipelines successfully started running 1 pipeline(s).

hananiel
hananiel previously approved these changes Oct 10, 2023
View reviewed changes
bart-vmware
bart-vmware reviewed Oct 11, 2023
View reviewed changes
Comment thread src/Common/test/Common.Security.Test/CertificateRotationServiceTest.cs Outdated
bart-vmware
bart-vmware reviewed Oct 11, 2023
View reviewed changes
Comment thread src/Common/test/Common.Security.Test/CertificateRotationServiceTest.cs Outdated
bart-vmware
bart-vmware reviewed Oct 11, 2023
View reviewed changes
Comment thread src/Common/test/Common.Security.Test/CertificateRotationServiceTest.cs Outdated
bart-vmware
bart-vmware reviewed Oct 11, 2023
View reviewed changes
Comment thread src/Common/test/Common.Security.Test/CertificateRotationServiceTest.cs
@TimHess @bart-vmware
Apply suggestions from code review
f649562 
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 11, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@TimHess TimHess requested a review from hananiel October 11, 2023 15:33
@TimHess TimHess merged commit a662cc1 into release/3.2 Oct 11, 2023
@TimHess TimHess deleted the x509constructor branch October 11, 2023 19:31
@TimHess TimHess mentioned this pull request Dec 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bart-vmware bart-vmware bart-vmware left review comments

+1 more reviewer

@hananiel hananiel hananiel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TimHess TimHess

Labels

Component/Common Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimHess @hananiel @bart-vmware