Fix issue where "Spring:Cloud:Config:Timeout" configuration property isn't respected#1208
Merged
Merged
Conversation
The _httpClient field was being initialized using the "default" timeout setting and was not updated with the configured timeout. Fixed by deferring initializing the _httpClient field until after the settings are updated with the configured values. Addresses SteeltoeOSS#1178
Author
|
@dotnet-policy-service agree company="General Electric" |
Member
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TimHess
added
Type/bug
|
Kudos, SonarCloud Quality Gate passed! |
TimHess
added a commit
that referenced
this pull request
Dec 8, 2023
5 tasks
TimHess
added a commit
that referenced
this pull request
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ConfigServerConfigurationProvider's _httpClient field was being initialized using the "default" timeout setting and was not updated with the configured timeout. Fixed by deferring initializing the _httpClient field until after the settings are updated with the configured values.
Fixes #1178
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.