Fix issues with refresh polling#1219
Merged
Merged
Conversation
Expose defect where application crashes due to an unhandled exception during polling (which can happen when FailFast is enabled)
Refresh polling should also be disabled
- Fixes issue where application crashes when FailFast is enabled and an exception is thrown during refresh polling. - Fixes issue where refresh polling is not disabled when Enabled is set to false. Addresses SteeltoeOSS#1217 and SteeltoeOSS#1218
Member
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TimHess
reviewed
Nov 20, 2023
TimHess
added
Type/bug
TimHess
previously approved these changes
Nov 20, 2023
Member
TimHess
left a comment
TimHess
left a comment
There was a problem hiding this comment.
LGTM, just a nit on the log message
Member
|
Thanks for filing the issues and opening the PR! We will need to make sure this change gets applied to |
Change the way the exception is logged.
TimHess
approved these changes
Nov 20, 2023
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
No problem. We are hoping 3.2.6 will be released fairly soon so that we can continue to use the polling feature without the potential for our app to crash. |
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
Hi @TimHess. We are wondering when the 3.2.6 version will be released with this fix. Are you able to give an update on that? |
Member
Author
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If polling was enabled along with the fail fast setting, it was possible for unhandled exceptions to be thrown within a Timer callback, which crashed the application. Also the polling was not disabled when the Enabled configuration was set to false. This PR wraps the load in the Timer callback within a try/catch. It also only starts polling if Enabled is true.
Fixes #1217
Fixes #1218
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.