Consul :: Add tests to cover health check path being used when heartbeat is off#1245
Merged
Merged
Conversation
- Add tests for heartbeat on/off - Add tests for negative port
d27f8f2 to
991347c
Compare
TimHess
reviewed
Jan 16, 2024
cieciurm
commented
Jan 17, 2024
This was referenced Jan 17, 2024
Member
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Member
|
CI failures are unrelated |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Hi all,
This PR fixes an issue when health check path is not respected when heartbeat is enabled.
This is a very simple attempt to fix the issue, by moving the short circuiting statement couple of lines lower.
Please let me know if it's too simple ;)
I've added unit tests to cover the issue scenario.
As a bonus, I've added a unit test to assert an exception being thrown when the specified port is a negative number.
If the solution is approved, then I can submit a similar fix for the v4 version (targeting
mainbranch)Fixes #1062
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.