Skip to content

Consul :: Port tests to cover health check path being used when heartbeat is off#1252

Merged
bart-vmware merged 6 commits into
SteeltoeOSS:mainfrom
cieciurm:tests/health-check-path
Jan 23, 2024
Merged

Consul :: Port tests to cover health check path being used when heartbeat is off#1252
bart-vmware merged 6 commits into
SteeltoeOSS:mainfrom
cieciurm:tests/health-check-path

Conversation

@cieciurm
Copy link
Copy Markdown
Contributor

@cieciurm cieciurm commented Jan 20, 2024

Description

Hi all,

This PR ports unit tests added in #1245 for 3.2.

It covers scenarios for setting health check path (HTTP) in respect to the heartbeat check.

It also adds unit tests to coner validation of negative port for HTTP check.

I hope it could be of some use in the v4 of Steeltoe.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Copy Markdown
Member

@cieciurm Thanks. Can you please address the reported code style verification failure? Note you can run ./cleanupcode.ps1 main locally to auto-fix most of them.

@cieciurm
Copy link
Copy Markdown
Contributor Author

cieciurm commented Jan 22, 2024

Hi @bart-vmware, thanks for your response!
I've adjusted the code. Thanks for the tip with the script, I didn't know that and was meticulously fixing it one by one 🙄

Copy link
Copy Markdown
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bart-vmware bart-vmware merged commit 2bee5d9 into SteeltoeOSS:main Jan 23, 2024
@cieciurm cieciurm deleted the tests/health-check-path branch January 26, 2024 17:52
@TimHess TimHess added this to the 4.0.0-m1 milestone Mar 4, 2024
@TimHess TimHess added the Component/Discovery Issues related to Steeltoe Service Discovery label Mar 4, 2024
@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants