Consul :: Port tests to cover health check path being used when heartbeat is off#1252
Merged
Merged
Conversation
Member
|
@cieciurm Thanks. Can you please address the reported code style verification failure? Note you can run |
Contributor
Author
|
Hi @bart-vmware, thanks for your response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi all,
This PR ports unit tests added in #1245 for
3.2.It covers scenarios for setting health check path (HTTP) in respect to the heartbeat check.
It also adds unit tests to coner validation of negative port for HTTP check.
I hope it could be of some use in the
v4of Steeltoe.Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.