Prevent EncryptionResolverProvider to be added multiple times (similar solution to issue as #1276_#1277
Merged
TimHess merged 6 commits intoApr 17, 2024
Conversation
fennekit
changed the title
bart-vmware
reviewed
Apr 16, 2024
Member
bart-vmware
left a comment
bart-vmware
left a comment
There was a problem hiding this comment.
Thanks, LGTM. #1278 fixes the broken build. After it got merged, this PR should be green.
Member
|
/azp run cleanup-code |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run cleanup-code |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@fennekit Can you fix the code style? It won't run automatically because the branch is on your fork. |
…ers' into preventmultiple_encryptionproviders # Conflicts: # src/Configuration/src/Encryption/EncryptionConfigurationExtensions.cs # src/Configuration/test/Encryption.Test/EncryptionConfigurationExtensionsTest.cs
Contributor
Author
|
Codestyle done. |
TimHess
added
Type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EncryptionResolverProvider is based on the work done for the PlaceholderProvider. To prevent multiple registrations of the provider some checks were added.
Fixes issue similar to #1276.