Skip to content

Update OpenTelemetry packages#1278

Merged
bart-vmware merged 2 commits into
mainfrom
update-otel-packages
Apr 17, 2024
Merged

Update OpenTelemetry packages#1278
bart-vmware merged 2 commits into
mainfrom
update-otel-packages

Conversation

@bart-vmware
Copy link
Copy Markdown
Member

@bart-vmware bart-vmware commented Apr 16, 2024

Description

Updates Steeltoe to depend on stable OpenTelemetry packages, where available. Fixes broken build.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

- EnableGrpcAspNetCoreSupport was replaced by environment variable OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_ENABLE_GRPC_INSTRUMENTATION, see https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.server.cs
- Replace usage of IDeferredTracerProviderBuilder, see open-telemetry/opentelemetry-dotnet#4228
@bart-vmware
Copy link
Copy Markdown
Member Author

/azp run Steeltoe.All

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link
Copy Markdown

@bart-vmware bart-vmware marked this pull request as ready for review April 16, 2024 13:30
@bart-vmware bart-vmware requested a review from TimHess April 16, 2024 13:30
@TimHess TimHess added Type/enhancement New feature or request ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Apr 16, 2024
Comment thread src/Management/src/Wavefront/Exporters/TagExtensions.cs Outdated
TimHess
TimHess previously approved these changes Apr 16, 2024
Copy link
Copy Markdown
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely minor suggestion, otherwise LGTM for current scope.

Co-authored-by: Tim Hess <tim.hess@broadcom.com>
@bart-vmware bart-vmware requested a review from TimHess April 17, 2024 11:35
@bart-vmware bart-vmware merged commit abc2e71 into main Apr 17, 2024
@bart-vmware bart-vmware deleted the update-otel-packages branch April 17, 2024 12:01
@TimHess TimHess added this to the 4.0.0-m1 milestone Jul 16, 2024
@bart-vmware bart-vmware added the Component/Management Issues related to Steeltoe Management (actuators) label Jan 11, 2025
bart-vmware added a commit that referenced this pull request Jul 30, 2025
- Bump vulnerable packages: OpenTelemetry.Instrumentation.Http, OpenTelemetry.Instrumentation.AspNetCore, OpenTelemetry.Extensions.Hosting
- Remove package OpenTelemetry.Exporter.Jaeger (only non-stable and vulnerable versions exist)
- The above requires a bump of Microsoft.Extensions.* packages to 8.0, because Otel lists them as minimal versions
bart-vmware added a commit that referenced this pull request Jul 30, 2025
- Bump vulnerable packages: OpenTelemetry.Instrumentation.Http, OpenTelemetry.Instrumentation.AspNetCore, OpenTelemetry.Extensions.Hosting
- Remove package OpenTelemetry.Exporter.Jaeger (only non-stable and vulnerable versions exist)
- The above requires a bump of Microsoft.Extensions.* packages to 8.0, because Otel lists them as minimal versions
bart-vmware added a commit that referenced this pull request Jul 31, 2025
* Add net8.0 target framework, reorder frameworks

* Fix build errors

* Fix broken tests, suppress hanging Resharper test runner

* Remove net8.0 target from Messaging/Stream/Integration (incompatible)

* Remove target for netcoreapp3.1

* Remove unused entries from versions.props, match up EF Core version

* Split package versions into exposed/non-exposed groups

* Bump vulnerable package: Newtonsoft.Json

* Bump vulnerable OpenTelemetry packages (backported from #1278)

- Bump vulnerable packages: OpenTelemetry.Instrumentation.Http, OpenTelemetry.Instrumentation.AspNetCore, OpenTelemetry.Extensions.Hosting
- Remove package OpenTelemetry.Exporter.Jaeger (only non-stable and vulnerable versions exist)
- The above requires a bump of Microsoft.Extensions.* packages to 8.0, because Otel lists them as minimal versions

* Bump vulnerable package: Microsoft.Extensions.Caching.Memory

* Bump vulnerable package: System.Text.Json

* Bump vulnerable package: System.Data.SqlClient

* Bump vulnerable package: Microsoft.Data.SqlClient

* Bump vulnerable package: Oracle.ManagedDataAccess.Core

* Bump vulnerable package: MongoDB.Driver

* Bump vulnerable package: Npgsql

* Bump some internal-only package versions

* Fix/suppress build warnings

* Fix broken tests

* Automated insertion of Obsolete attribute, affecting all public types below the following directories:
/src/CircuitBreaker/src/Abstractions
/src/CircuitBreaker/src/Hystrix.MetricsEventsCore
/src/CircuitBreaker/src/Hystrix.MetricsStreamCore
/src/CircuitBreaker/src/HystrixBase
/src/CircuitBreaker/src/HystrixCore
/src/Common/src/Common.Expression
/src/Common/src/Common.Kubernetes
/src/Common/src/Common.RetryPolly
/src/Common/src/Common.Utils
/src/Configuration/src/KubernetesBase
/src/Configuration/src/KubernetesCore
/src/Connectors/src/Connector.EF6Core
/src/Discovery/src/Kubernetes
/src/Integration/src/Abstractions
/src/Integration/src/IntegrationBase
/src/Integration/src/RabbitMQ
/src/Management/src/KubernetesCore
/src/Stream/src/Abstractions
/src/Stream/src/BinderRabbitMQ
/src/Stream/src/StreamBase
/src/Messaging/src/Abstractions
/src/Messaging/src/MessagingBase
/src/Messaging/src/RabbitMQ
/src/Security/src/DataProtection.CredHubBase
/src/Security/src/DataProtection.CredHubCore

* Manually mark remaining APIs obsolete

* Suppress obsolete warnings

* Apply patch from #1108

* Install .NET 8 in cibuild, fix trigger of component builds

* Remove redundant TargetFramework conditionals

* Remove redundant NET6_0_OR_GREATER conditionals

* Disable failing test in CI on Windows

* Package using GHA

* Change pipeline timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants