Conversation
Collaborator
daobrien
commented
Feb 2, 2023
daobrien
commented
- Ongoing updates for Run Vale over the style guide Part 2 #456
- Closes Run Vale over the style guide Part 2 #456
Merge all updates from dev to master for 6.0 release
julian-cable
reviewed
Feb 2, 2023
en-US/Language.xml
Outdated
| <para> | ||
| "Visit the following web link to dig deeper into [subject] ...". Using "dig deeper" may translate awkwardly. Consider rewording: "For detailed information regarding [subject], see [link]." | ||
| "Visit the following web link to dig deeper into [subject] ...". | ||
| Using "dig deeper" may translate awkwardly. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Using "dig deeper" may translate awkwardly. | |
| Using "dig deeper" might translate awkwardly. |
Collaborator
Author
There was a problem hiding this comment.
Sheesh. pick pick pick. That's supposed to fall under your bug of "follow our own rules" 😛
Collaborator
There was a problem hiding this comment.
I thought that would fall under the banner of what Vale catches. And if it doesn't catch "may" already, maybe it should?
julian-cable
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.