Skip to content

feat: s-form-page, c-form--login, s-form--login#205

Merged
wesleyboar merged 10 commits intomainfrom
feat/WP-63-tapis-tacc-login-page
Aug 1, 2023
Merged

feat: s-form-page, c-form--login, s-form--login#205
wesleyboar merged 10 commits intomainfrom
feat/WP-63-tapis-tacc-login-page

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 27, 2023

Overview / Changes

  1. Create c-form--login (component) and s-form--login (scope).
  2. Create s-form-page (for a page that is just one form).

Related

Testing

Form Page

  1. Open the pattern:
  2. Verify the pattern is styled identically to the box on https://www.tacc.utexas.edu/portal/login.

Login Form

  1. Open these patterns:
  2. Verify those forms are styled identically.
  3. Verify the c-form uses many class names.
  4. Verify the s-form uses few class names.
  5. Verify both forms are styled identically to the form in the box on https://www.tacc.utexas.edu/portal/login.

UI

Login Form

c-form c-form--login s-form s-form--login
c-form--login s-form--login

Form Page

s-form-page (default) s-form-page (example)
s-form-page default s-form-page example

@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Jul 27, 2023
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Jul 27, 2023
@wesleyboar wesleyboar changed the title feat: c-form-page feat: c-form-page, c-form--login, s-form--login Aug 1, 2023
@wesleyboar wesleyboar marked this pull request as ready for review August 1, 2023 16:41
@wesleyboar wesleyboar changed the title feat: c-form-page, c-form--login, s-form--login feat: s-form-page, c-form--login, s-form--login Aug 1, 2023
@wesleyboar
Copy link
Member Author

Reviewed with H.P. and J.S. for WP-63. This design is adequate for that, which is the first use case.

@wesleyboar wesleyboar merged commit 6d7effe into main Aug 1, 2023
@wesleyboar wesleyboar deleted the feat/WP-63-tapis-tacc-login-page branch August 1, 2023 20:31
@wesleyboar wesleyboar mentioned this pull request Sep 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature or replacement of existing feature minor A feature in backward-compatible manner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant