feat: s-form (and refactor c-form and django-cms-forms)#207
Merged
wesleyboar merged 19 commits intomainfrom Jul 31, 2023
Merged
feat: s-form (and refactor c-form and django-cms-forms)#207wesleyboar merged 19 commits intomainfrom
wesleyboar merged 19 commits intomainfrom
Conversation
TODO: c-form and s-form should share one template
Also: - fix minor space bugs - fix new selector bugs
Removes `form.cms.css`. - No problem if you already: - load `core-styles.cms.css` - load `core-styles.docs.css` Adds form styles to `core-styles.base.css`. - No problem if you already: - load `core-styles.cms.css` - load `core-styles.docs.css` - Style influx if you: - load `core-styles.portal.css`
Make toggle-required-fields.js work on all forms, and document it.
They should incldue everythign they rely on. Now they do. Notice core-styles/*.css changes are meerely removal of comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview / Changes
s-formas a scope-version ofc-form.c-formto style:c-form,s-form,django-cms-forms.<menu>for lists of interface elements.elements/form.cms.csstoelements/form.css.elements/form.csstocore-styles.base.css.elements/form.cms.csselements/django-cms-forms--errors-via-c-message.cssRelated
s-formfrom MFA pairing UI/accessibility tweaks - design changes tup-ui#270Testing
Remember to "Toggle Field Errors" (button at bottom of form).
Remember to "Toggle Field Errors" (button at bottom of form).
The error messages are not styled, because clients have their own styles.
It is not a real field. It is JavaScript Captcha. It can not be un-required.
UI
s-form.c-form.django-cms-forms.mov