fix: tup-659 all form fields too short#267
Merged
wesleyboar merged 3 commits intomainfrom Nov 21, 2023
Merged
Conversation
1. Remove field width stretch from CMS and Login. 2. Add field width stretch to all forms. 3. Support form width stretch only if NOT a checkbox.
No need to avoid stretching fieldw rapper that has a checkbox. A checkbox (and others) are already explicitely told not to stretch.
wesleyboar
commented
Nov 21, 2023
Comment on lines
-68
to
-73
| /* To make elements bigger */ | ||
| & :--form__field:not(:--form__field--has-checkbox) { | ||
| /* To stretch input field width */ | ||
| display: flex; | ||
| flex-direction: column; | ||
| } |
Member
Author
There was a problem hiding this comment.
This was added in #225, but as the wrong solution to a specificity problem.
Comment on lines
+42
to
+43
| display: flex; | ||
| flex-direction: column; |
Member
Author
There was a problem hiding this comment.
All form fields, Portal or CMS, checkbox or not, should be stretched. Whether the <input> itslef is stretched, is managed by styles specific to certain <input> fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stretch most input fields* of all form types to same width.
* Not checkboxes nor time nor date nor radio boxes.
Related
Changes
* The radio and time and date fields are unaffected for different reason.
Testing
UI
Skipped.
Notes
We should not need
:--form__field--not-checkbox(05f6f32) ever. I had added that, but then removed it in 70d3f28. All form fields, Portal or CMS, checkbox or not, should be stretched. Whether the<input>itself is stretched, is managed by styles specific to certain<input>fields.