Skip to content

fix: carousel 로직 복구#128

Merged
ho0010 merged 2 commits into
developfrom
feat/api-rooms
Aug 16, 2025
Merged

fix: carousel 로직 복구#128
ho0010 merged 2 commits into
developfrom
feat/api-rooms

Conversation

@ho0010

@ho0010 ho0010 commented Aug 16, 2025

Copy link
Copy Markdown
Collaborator

fix: carousel 로직 복구

Summary by CodeRabbit

  • 스타일

    • 그룹 캐러셀의 페이지 점(도트) 인디케이터를 제거해 화면을 간결하게 정리했습니다.
    • 스크롤 시 카드 스케일 효과를 다듬어 가독성과 몰입감을 개선했습니다.
    • 리크루팅 그룹 캐러셀 높이를 800px로 조정했습니다.
  • 신규 기능

    • 그룹 페이지 카테고리 구성을 업데이트하여 ‘인플루언서·작가 독서 모임방’ 섹션을 제거했습니다.

@vercel

vercel Bot commented Aug 16, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 16, 2025 9:00am

@coderabbitai

coderabbitai Bot commented Aug 16, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

carousel 공통 훅(useInfiniteCarousel)에 옵션(scaleAmount) 추가 및 시그니처 변경. 이를 반영해 RecruitingGroupCarousel가 훅 기반으로 리팩터링됨. MyGroupBox에서 점(페이지 인디케이터) UI 제거. Group 페이지에서 세 번째 카테고리(인플루언서·작가) 섹션 삭제.

Changes

Cohort / File(s) Summary of changes
Carousel Hook Update
src/hooks/useInfiniteCarousel.ts
훅 시그니처를 useInfiniteCarousel(groups, options?)로 확장하고 scaleAmount 옵션(기본 0.17) 도입. 스케일 계산 및 스크롤 핸들러 의존성에 옵션 반영.
Carousel Consumer - MyGroupBox
src/components/group/MyGroupBox.tsx
훅 반환값에서 current 사용 제거. 점 인디케이터(Dots, Dot) 스타일/렌더링 삭제. 나머지 렌더/네비게이션 로직 유지.
Carousel Consumer - RecruitingGroupCarousel
src/components/group/RecruitingGroupCarousel.tsx
수동 스크롤/스케일/센터링 로직 제거 후 useInfiniteCarousel 도입. sectionssectionGroups로 변환해 훅에 공급. infiniteGroups 기반 렌더, 키 생성 규칙 변경, refs 정리, 아이템 높이 스타일 추가.
Group Page Sections
src/pages/group/Group.tsx
"인플루언서·작가 독서 모임방" 섹션 제거. 초기/성공/에러 경로 모두에서 해당 섹션 제외.

Sequence Diagram(s)

sequenceDiagram
  participant Page as Group Page
  participant Comp as RecruitingGroupCarousel
  participant Hook as useInfiniteCarousel
  participant DOM as Scroll Container & Cards

  Page->>Comp: sections 전달
  Comp->>Comp: sections → sectionGroups 변환
  Comp->>Hook: useInfiniteCarousel(sectionGroups, {scaleAmount?})
  Hook-->>Comp: {scrollRef, cardRefs, infiniteGroups}
  Comp->>DOM: scrollRef, cardRefs 바인딩
  DOM-->>Hook: scroll 이벤트
  Hook-->>DOM: 카드 스케일/리센터 계산 적용
  Comp->>Comp: infiniteGroups 기반 렌더
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

✨ Feature

Suggested reviewers

  • heeeeyong
  • ljh130334

Poem

오늘도 나는 토끼, 캐러셀을 빙글빙글—
점표시는 안녕, 스크롤은 훅에 싱글싱글.
제목과 그룹이 한 바구니에 콩콩,
스케일은 옵션으로 살짝 콩닥콩닥.
세 번째 길은 접고, 두 발로 폴짝! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 20421fb and 02e066a.

📒 Files selected for processing (4)
  • src/components/group/MyGroupBox.tsx (1 hunks)
  • src/components/group/RecruitingGroupCarousel.tsx (3 hunks)
  • src/hooks/useInfiniteCarousel.ts (4 hunks)
  • src/pages/group/Group.tsx (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/api-rooms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ho0010 ho0010 merged commit 38bfac9 into develop Aug 16, 2025
2 of 3 checks passed
@heeeeyong heeeeyong assigned heeeeyong and ho0010 and unassigned heeeeyong Aug 16, 2025
@heeeeyong heeeeyong added the 📬 API 서버 API 통신 label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📬 API 서버 API 통신

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants