Skip to content

develp branch 작업내용 머지 : develop -> main#209

Merged
heeeeyong merged 10 commits into
mainfrom
develop
Aug 27, 2025
Merged

develp branch 작업내용 머지 : develop -> main#209
heeeeyong merged 10 commits into
mainfrom
develop

Conversation

@heeeeyong

@heeeeyong heeeeyong commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

이하동일

Summary by CodeRabbit

  • 신기능 없음

  • 버그 수정

    • 검색 화면에서 고정 헤더(56px)와 검색바가 겹치지 않도록 오프셋을 적용.
    • 최근 검색어가 삭제 후 및 검색 상태가 idle로 돌아올 때 자동 새로고침. 검색 진행 중에는 불필요한 요청 방지.
  • 스타일

    • 헤더 최대 너비를 767px로 조정.
    • 모달 오버레이를 min-height(100vh) + 상단 패딩 56px로 변경해 레이아웃/스크롤 안정화.
    • 검색바 상단 여백 16px, 많이 검색한 도서 상단 패딩 32px로 조정.
    • 그룹/검색 페이지에 상단 패딩 56px 및 레이아웃 높이 조정.
    • 캐러셀 고정 높이 제거, 리크루팅 박스 높이 보완.

@heeeeyong heeeeyong merged commit 8a7a90a into main Aug 27, 2025
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Aug 27, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

검색/그룹/피드 화면 전반의 레이아웃 보정과 최근검색 로딩 타이밍을 조정했습니다. 헤더 높이/오프셋 정렬, 모달 오버레이의 min-height 및 패딩 도입, 그룹 컴포넌트 높이 규칙 조정, 캐러셀 항목 고정 높이 제거, 일부 패딩/마진 값 변경과 최근검색 재조회 트리거 추가가 포함됩니다.

Changes

Cohort / File(s) Summary
Header width tweak
src/components/common/TitleHeader.tsx, src/pages/Guide.tsx
헤더 max-width 766px → 767px로 1px 조정.
Modal overlay layout
src/components/group/Modal.styles.ts
Overlay: height: 100vhpadding-top: 56px + min-height: 100vh; Modal는 height: 100vh 유지.
Group components sizing
src/components/group/RecruitingGroupBox.tsx,
src/components/group/RecruitingGroupCarousel.tsx,
src/pages/group/Group.tsx
박스 컨테이너 height: 100% 추가, EmptyContent height: 133px 추가. 캐러셀 아이템 고정 높이 800px 제거. Group 페이지 래퍼 align-items: flex-start, min-height: 100vh, padding-top: 56px로 변경.
Search UI spacing/alignment
src/components/search/MostSearchedBooks.tsx, src/components/search/SearchBar.tsx, src/pages/search/Search.tsx
MostSearchedBooks 상단 패딩 36px → 32px. SearchBar 상단 마진 76px → 16px. Search 페이지 헤더 높이 56px 지정, SearchBar 컨테이너 top 0 → 56px.
Recent search fetch logic
src/pages/feed/UserSearch.tsx, src/pages/groupSearch/GroupSearch.tsx
UserSearch: isSearched 의존 useEffect로 초기/idle 시 최근검색 조회, 삭제 후 await fetchRecentSearches()로 리스트 갱신, SearchBarContainer top 0 → 56px. GroupSearch: searchStatus === 'idle' 시 최근검색 재조회 effect 추가.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant US as UserSearch
  participant API as RecentSearch API

  U->>US: 페이지 진입
  activate US
  US->>US: isSearched === false?
  alt not searched
    US->>API: fetchRecentSearches()
    API-->>US: 최근검색 목록
    US-->>U: 목록 렌더
  else searched
    US-->>U: 목록 비갱신
  end

  U->>US: 최근검색 삭제
  US->>API: deleteRecentSearch(id)
  API-->>US: 삭제 성공
  US->>API: fetchRecentSearches()  %% 변경된 흐름
  API-->>US: 최신 목록
  US-->>U: 목록 갱신
  deactivate US
Loading
sequenceDiagram
  autonumber
  actor U as User
  participant GS as GroupSearch
  participant API as RecentSearch API

  U->>GS: 페이지 진입
  GS->>API: fetchRecentSearches()
  API-->>GS: 최근검색 목록
  GS-->>U: 목록 렌더

  U->>GS: 검색 수행
  GS->>GS: searchStatus = 'loading'/'success'
  U->>GS: 검색 종료/초기화
  GS->>GS: searchStatus = 'idle'
  GS->>API: fetchRecentSearches()  %% idle 시 재조회 추가
  API-->>GS: 최신 목록
  GS-->>U: 목록 갱신
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

🎨 Html&css

Suggested reviewers

  • ho0010

Poem

폴짝, 헤더는 한 픽셀 키 컸다네
모달은 패딩으로 숨 고르네
캐러셀, 높이 굴레 벗어났고
검색창은 헤더 밑에 차곡차곡
최근검색 토토톡, 새로 담고 뛰어볼까?
(_(:3」∠)_) ʕ•ᴥ•ʔ (\_/)<|vq_14470|>

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24b8540 and 282b20f.

📒 Files selected for processing (11)
  • src/components/common/TitleHeader.tsx (1 hunks)
  • src/components/group/Modal.styles.ts (1 hunks)
  • src/components/group/RecruitingGroupBox.tsx (2 hunks)
  • src/components/group/RecruitingGroupCarousel.tsx (1 hunks)
  • src/components/search/MostSearchedBooks.tsx (1 hunks)
  • src/components/search/SearchBar.tsx (1 hunks)
  • src/pages/Guide.tsx (1 hunks)
  • src/pages/feed/UserSearch.tsx (3 hunks)
  • src/pages/group/Group.tsx (1 hunks)
  • src/pages/groupSearch/GroupSearch.tsx (1 hunks)
  • src/pages/search/Search.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel

vercel Bot commented Aug 27, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 27, 2025 3:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant