Merged
Conversation
…HUDM#260) Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: zijiexia <zijie_xia@icloud.com> Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com>
…#393) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
zhuzilin
approved these changes
Jan 5, 2026
| if args.fp16: | ||
| kwargs["dtype"] = "float16" | ||
| elif args.bf16: | ||
| kwargs["dtype"] = "bfloat16" |
Contributor
There was a problem hiding this comment.
I think we can use the default value from sglang because when using fp8 in megatron, the args.bf16 will still be True.
slime/ray/rollout.py
Outdated
| sum(response_lengths) / rollout_time / args.rollout_num_gpus | ||
| ) | ||
| log_dict["perf/longest_effective_sample_tokens_per_sec"] = max(response_lengths) / rollout_time | ||
|
|
Contributor
There was a problem hiding this comment.
this part has been merged into compute_perf_metrics_from_samples.
slime/ray/rollout.py
Outdated
| log_dict = {} | ||
| log_dict |= dict_add_prefix(compute_statistics(response_lengths), "response_len/") | ||
| log_dict |= _compute_zero_std_metrics(args, samples) | ||
| log_dict |= _compute_spec_metrics(args, samples) |
slime/ray/rollout.py
Outdated
| ) | ||
| metrics["rollout/spec_accept_length"] = ( | ||
| sum(sample.spec_info.spec_accept_length for sample in all_samples) / num_samples | ||
| ) |
| # Precision | ||
| gradient_checkpointing: bool = False | ||
| fp16: bool = False | ||
| bf16: bool = False |
Contributor
There was a problem hiding this comment.
hmm, I don't think bf16 param for fsdp is necessary because in the megatron side, the bf16 is a default setting.
zhuzilin
approved these changes
Jan 5, 2026
kafkayu
pushed a commit
to kafkayu/slime
that referenced
this pull request
Jan 8, 2026
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: zijiexia <zijie_xia@icloud.com>
Yangruipis
pushed a commit
to rednote-ai/slime
that referenced
this pull request
Feb 28, 2026
Co-authored-by: zhaochenyang20 <zhaochen20@outlook.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: zijiexia <zijie_xia@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sync these three commits:
Thanks!