add background health check to miles native router#260
Merged
zhaochenyang20 merged 9 commits intoradixark:mainfrom Jan 5, 2026
Merged
add background health check to miles native router#260zhaochenyang20 merged 9 commits intoradixark:mainfrom
zhaochenyang20 merged 9 commits intoradixark:mainfrom
Conversation
Contributor
Author
|
@fzyzcjy Does this look good or I need to change my approach?. Thanks. |
Contributor
Author
|
A gentle remainder about this @fzyzcjy if you were busy. Thanks |
zhaochenyang20
requested changes
Dec 23, 2025
Collaborator
|
/gemini review |
zhaochenyang20
requested changes
Dec 23, 2025
zhaochenyang20
changed the title
zhaochenyang20
requested changes
Dec 30, 2025
zhaochenyang20
requested changes
Dec 30, 2025
zhaochenyang20
requested changes
Dec 30, 2025
Clarified TODO comment regarding re-enabling dead workers and model version synchronization.
zhaochenyang20
approved these changes
Dec 31, 2025
Collaborator
zhaochenyang20
left a comment
zhaochenyang20
left a comment
There was a problem hiding this comment.
All my feadback is resolved. Let me ask Chengxing for a final look.
Collaborator
|
@yitianlian approved this change |
Collaborator
|
lgtm~ |
yueming-yuan
approved these changes
Jan 1, 2026
Collaborator
|
@Ratish1 Will merge this PR after the code sync,. |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a background health check for the router component, resolving the TODO in miles/router/router.py. A background asyncio task is started on startup that periodically (default 30s) pings all registered workers. Workers that return a non-200 status or fail to connect are removed from the active pool. This ensures that traffic is not routed to unhealthy or dead workers. #259 @fzyzcjy