10.0 - #41
Open
krysthian93 wants to merge 2357 commits into
Open
Conversation
Force the location and destination location's company to match with the picking and picking type company. This is to prevent users to move products between companies without using a transit location, since stock valuation is not supported. The record rule `stock_location_comp_rule` gives access to children companies. The domain added in the view is more restrictive, and allows, for a company A, transfers from locations: Company A -> Company A Company A -> No Company No Company -> Company A opw-1893276 closes odoo/odoo#30952
Before this, groups on non-stored inverse fields were not checked upon write. The impact on existing fields is pretty small, since the inverse methods of those fields are subject to access rights on the records they use. closes odoo/odoo#30356
Revert commit 296c5a2 which was half-right: the accounting logic is correct but it overlooked that it broke the reconciliation of cash returns i.e. the client gives more money, and you return the change Given that this latter use case may occur more frequently we focus on that while we break freight returns i.e. the client returns a product, and you give the money back It is not possible to support both use cases because ultimately we don't know from which order an account.move.line comes the related PR #23356 should support both use cases but adds a field on account.move.line OPW 1925607 closes odoo/odoo#31037
Calling `search` on `product.product` without specifying an order will sort the products by name. As the product name is a translatable field, it requires to make a join on the translation table to sort the product by their translated name. This join is costly, and in this case it was completely irelevant to do it, as the goal was simply to compute a domain with only a list of product ids, for which the order simply did not matter. By forcing the order on the id, we avoid the sort on the product name, and therefore the join on the translation. The performance is therefore improved. opw-1930010 closes odoo/odoo#31066
This commits adds a message to the module import wizard to make it more clear what kind of modules can be imported through the front end. project : RD feedback task : [base_import_module] what it is not for. opw-1939967 closes odoo/odoo#31057
The html widget automatically replace an empty field value by `<p><br></p>` to be able to add content. But this may cause unintended "onchange", since the value has "changed" and the onchange themself could cause error when triggered at the wrong time (eg. inside a list view with required fields). With this changeset, the onchange is averted when the value was false and is now `<p><br></p>`. opw-1906581 closes #31078
When an inline editor is eg. in a form view, the focus is always stolen by it. This is because we trigger a mouseup on the editor to update its toolbars values and informations. note: backport of 11.0's 7a453b0 In 10.0 this trigger could cause a "blur" which in some instance is not wanted (eg. inside a newline of a list view). opw-1906581 closes #31078
openerp-italia.org or odoo-italia.org are not valid websites changing it to odoo.com OPW 1940848 closes odoo/odoo#31110
… access This is the first step to a more comprehensive handling of company-dependent fields which are ir_properties. With model-specific access rights, users should be able to read/update a company-dependent field no matter their access rights on ir_property. Before this commit, a user having access to res.partner, but not to ir.property couldn't write on property_account_receivable/payable just because he couldn't write the corresponding ir.property. After this commit, he can. OPW 1923345
In Odoo, create a user John@example.com (the cap is on purpose) In Google Calendar, create an event and invite john@example.com Sync your Google calendar. Before this revision, the event created in Odoo did not add John@example.com, but created a new attendee, john@example.com, because of the sensitive casing. Besides, give the priority to partners having users, so if there are two partners with the same email, one of them having a user, e.g. John@example.com (with user) & john@example.com (without user), set the partner having the user as attendee, as its the one with the user who use the Odoo calendar, and potentially the Google sync as well. opw-1925592 closes odoo/odoo#31111
…erged_modules [10.0] [UPD] website_blog_share: Merged module
There is no `company_id` field on `stock.picking.type`. Partially revert f221936 (#30952) closes odoo/odoo#31121
Before this patch, any exception raised by a constraint method that were not of type `ValidationError` were hard to debug, because the origin line was never logged. Explicitly logging the error (with traceback) when we catch it ensures proper contextual info, even in the absence of exception chaining. closes odoo/odoo#28612
On IE11, in 10.0 up to master in some instance when creating a record under some conditions the dropdown may be automatically opened and need to be closed. This has been pinpointed to 90c1af1 so it seem that a combination of fields/code/autocomplete and changing the placeholder at one time causes the issue. Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1 when the browser is chrome (we did no did this at first to have the same behavior accross browsers). note: there is an opened bug in chromium https://crbug.com/928305 if solved the hack could be removed completely. opw-1940592 closes #31271
…183f92de4 Without conflicts
[10.0] update upstream 8183f92
…ustomer_code_sale [FIX] apriori incorrect rename (product_supplierinfo_for_customer_sale)
When website_customer is not installed, some endpoints are not handled by the router, causing the following tests to fail: - test_10_crawl_public - test_20_crawl_demo - test_30_crawl_admin Those tests were failing due to /customers responding with 404. Indeed, the route /customers is defined in website_customer, but had some usage within website_crm_partner_assign, causing tests to fail when the former module is not installed. The new behavior can be explained as follows: - module website_crm_partner_assign on its own will lose the hyperlink. - module website_customer will now inherit the view definition in order to wrap the targeted HTML text elements with an anchor tag. Closes #33344 Signed-off-by: Christophe Simonis <chs@odoo.com>
With some escpos printers the cash drawer did still not open after previous fixes. One of the problemetic printers is the Epson TM-m30. This fix will check the status of the drawer and try to open it up to 5 times. The fix is successfully tested with the TM-m30. closes odoo/odoo#33328 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
This revision is a backport of revision 56596e5 As the bug mentioned in the above revision occurs as well in Odoo 10.0 and 11.0. opw-1984293 closes odoo/odoo#33382 Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
Rounding each element of the sum decrease the precision and prevent to reconcile large recordset. closes odoo/odoo#33100 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Luis Felipe Mileo <mileo@kmee.com.br>
[MIG][l10n-brazil] Merged modules
When multiple emails (`mail.mail`) are linked
to the same message (`mail.message`),
all the message notifications were being marked as sent
as soon as one of the mail was sent, and not all of them.
This is indeed possible to have multiple emails linked to a single
message, for instance when there are employees and customers in
the followers of a thread, and some must therefore have
the buttons meant for the employees ("Assign me") and some not.
In other words, it was possible notifications were marked
as sent while their associated email was not sent yet.
This revision also comes as an addition to
5d6656d
as it was possible to receive a bounce coming from
the previous mail sent which wrote on the same notifications `email_status`
than the current message being sent before we could acquire the lock on
them (see commit message of the above mentioned revision),
as it was writing the `email_status` on more notifications that it
should have, including notifications of the previous email.
e.g
- Mail 1
- Message 1
- Recipient A, B, C
- Mail 2
- Message 1
- Recipient D, E
Let's say recipient A bounces
If the email notifying the bounce arrives during the processing of the "Mail 1",
it will be blocked until we release the lock on the `mail.notification` `email_status`
we acquire thanks to having written `exception` on `email_status` before sending the email.
But, as soon as it is unblocked (after the `cr.commit()`),
it will immediately re-attempt the delivery of the bounce email,
therefore writting "bounced" in `email_status` of recipient A,
while the transaction of the second email already began.
When the second email sending will try to write the `email_status`
of recipient A as well
(as it used to write the `email_status` on all the message notifications,
not just the one related to the current email),
it raised a concurrent update.
Therefore:
1. Interrupting the loop, as psycopg2 exceptions are raised and not passed,
2. Replay the sending of the second email a second time.
opw-1984293
closes odoo/odoo#33431
Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
Traceback generated when trying to pass a datetime object into a function tag in xml. <function name="action_name" model="model_name" eval="datetime.date.today"/> Used to fail. With this commit now one can pass time, datetime, timedelta, relativedelta, version, ref, pytz in function tag in xml Task-id: 1772614 Closes odoo/odoo#29212 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Co-authored-by: Dhaval Limbuwala <dli@odoo.com>
…t_creation_sql [10.0][IMP] Performance of payment creation for statement lines
Fixes #2339 * add loaded models and fields to the set of loaded XMLIDs * purge models and fields with noupdate NULL instead of FALSE Also * remove coverage as it is giving out red marks to PRs for no reason * check reference count before deleting a record after module upgrade * improve logging when deletion fails (should be rare now) * reduce logging of deletions in CI * remove ir.model.relation from ir.model's unlink This PR is part of a set of PRs for OpenUpgrade 9.0 up to 13.0. Background: While Odoo deletes obsolete field and model entries from the data model metadata explicitely in their migration scripts, in OpenUpgrade I have always meant to rely on the mechanism of purging 'untouched' XMLIDs that takes care of the deletion of obsolete data records (e.g. views). However, this mechanism was not applied to field and model entries because their XMLIDs were created with noupdate NULL instead of FALSE and as such excluded in the query to gather all obsolete data records. Also missing was marking the XMLIDs of fields and models as loaded in the first place. All of this is working properly in Odoo 13 (introduced gradually across new releases) so all of this is backported from newer versions one way or another.
…al_features [10.0][OU-MRG] admin_technical_features
[10.0][IMP] Set invoices paid
…re_null [10.0][OU-FIX] #2339, purge obsolete models and fields
[IMP] Generate stock_move_lots entries for mrp_production's
The sheets where already preserved in #2327, but new sheets were still created for the related expenses.
…eets_from_8.0 [10.0][OU-IMP] Reuse the rescued expense sheets from Odoo 8.0
delivered quantities
[10.0][IMP] recompute invoice_status for po's with products invoiced by delivered quantities
Manual backport of #42011 see also #41407
…c3f51c487 No conflicts.
[10.0] update upstream 28c3f51
It was marked as noupdate=1 and it disappears, but no action was taken. We remove it manually for not collapsing later.
…logger [FIX][10.0] replace print by logger
[10.0][OU-ADD] stock_landed_costs: Nothing to do
On this phase of the upgrade, ORM operations are very limited, as most models are not yet loaded, so we need to perform the merge by SQL for avoiding for example missing m2o replacements if the target model is not yet loaded. Specific problem where I have found the issue is on `product_instrastat` module that adds a country m2o in `account.invoice`, and this one is not changed and when removing the record, the fk constraint is triggered. TT30237
[10.0][FIX] base: Merge records through SQL
Asking for a specific `openupgradelib` version from `master` is very limiting, as installing OpenUpgrade will likely override any different version you might want to have in your environment. Instead, we should ask for the dependency from a generic version (or, if a minimal version is necessary, use semver standards instead) and allow the user ti install another specific version if needed. @Tecnativa
[10.0][FIX] Ask for unversioned openupgradelib in requirements
[10.0][FIX] fix fill_stock_move_unit_factor perf and use openupgrade.logged…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr