Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Move local-only and local-storage collections to main @tanstack/db package - Create new @tanstack/db-electric-collection package for Electric SQL integration - Create new @tanstack/db-query-collection package for TanStack Query integration - Delete @tanstack/db-collections package (to be deprecated on npm separately) - Update example app and documentation to use new package structure This reorganization provides better separation of concerns and allows each collection type to have independent versioning and dependencies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: cf110f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tanstack/db-example-react-todo @tanstack/db
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/vue-db
commit: |
|
Size Change: +2.93 kB (+9.3%) 🔍 Total Size: 34.4 kB
ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 1.05 kB ℹ️ View Unchanged
|
The type tests were importing from @tanstack/db but we're now inside that package, so we need to use relative imports to ../src/types instead.
samwillis
left a comment
There was a problem hiding this comment.
LGTM
My only hesitation is on package names. It would be nice is the collection packages had a common prefix so that they sorted/grouped together:
@tanstack/db-collection-electric
@tanstack/db-collection-query
but that doesn't quite read as well.
|
We chatted offline and decided to change the names to follow the general tanstack pattern of specific-integration dash type-of-thing e.g. react-db or react-query — electric dash db-collection follows that same pattern. |
Co-authored-by: Claude <noreply@anthropic.com>
Summary
@tanstack/dbpackage@tanstack/electric-db-collectionpackage for Electric SQL integration@tanstack/query-db-collectionpackage for TanStack Query integration@tanstack/db-collectionspackage (removed from repo)Benefits
Package Names Review
@reviewers: Please weigh in on the new package names:
@tanstack/electric-db-collection@tanstack/query-db-collectionAre these names clear and intuitive? Any suggestions for improvements?
NPM Deprecation
After merge & release, run this command to deprecate the old package:
npm deprecate @tanstack/db-collections "This package has been split into @tanstack/db (for local collections), @tanstack/electric-db-collection, and @tanstack/query-db-collection"Test plan
@tanstack/dbpackage🤖 Generated with Claude Code