Updating to 1.129.0 broke my app.

[johannesbremer]

Which project does this relate to?

Start

Describe the bug

I'm using TanStack Start and today dependabot updated me to 1.129.0: https://github.com/johannesbremer/praxisplaner/commit/1ff2e8a7394bd06c011c9871d534c0637861d088. I've also locally reverted the commit and only updated the TanStack part to make sure, this is what was causing the issue. What happens is, that when I click on either of the routes from the root page (or load them by going to localhost:5173/regeln or localhost:5173/praxisplaner) they just hang on my custom loading messages. The browser console prints (also in the root page):

content.js:1 [PVS Connector] Content script loaded.
@tanstack_react-start.js?v=9923bdfb:17 Module "node:async_hooks" has been externalized for browser compatibility. Cannot access "node:async_hooks.AsyncLocalStorage" in client code. See https://vite.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
get @ @tanstack_react-start.js?v=9923bdfb:17
(anonymous) @ @tanstack_react-start.js?v=9923bdfb:172
@tanstack_react-start.js?v=9923bdfb:172 Uncaught (in promise) TypeError: import_node_async_hooks.AsyncLocalStorage is not a constructor
    at @tanstack_react-start.js?v=9923bdfb:172:20
(anonymous) @ @tanstack_react-start.js?v=9923bdfb:172

Your Example Website or App

https://github.com/johannesbremer/praxisplaner

Steps to Reproduce the Bug or Issue

git clone https://github.com/johannesbremer/praxisplaner.git
pnpm i
pnpm dev

Expected behavior

I expect to be able to visit my routes.

Screenshots or Videos

No response

Platform

• Router / Start Version: 1.129.0
• OS: macOS
• Browser: Chrome, Safari, Firefox
• Bundler: vite
• Bundler Version: 7.0.5

Additional context

Thanks in advance! Let me know if there are things I can do.

[rialco]

I am also experiencing this issue after upgrading to 1.129.0 just as described by OP.

[Luks17]

Can confirm this same issue, downgrading does not solve the issue though. Maybe a critical dependency broke somehow?

[johannesbremer]

Can confirm this same issue, downgrading does not solve the issue though. Maybe a critical dependency broke somehow?

Downgrading to the the non broken version is possible for me. Did you perhaps forget to run pnpm install (or your package managers equivalent) after reverting the commit?

[TheDunco]

This seems to be the same issue as #4729

[johannesbremer]

Sorry, I didn't catch that one. Closed as duplicate of #4729.

[Luks17]

Can confirm this same issue, downgrading does not solve the issue though. Maybe a critical dependency broke somehow?

Downgrading to the the non broken version is possible for me. Did you perhaps forget to run pnpm install (or your package managers equivalent) after reverting the commit?

Nope, I'm even running rm -rf .tanstack node_modules pnpm-lock.yaml and then running pnpm install, still does not work.

[johannesbremer]

Can confirm this same issue, downgrading does not solve the issue though. Maybe a critical dependency broke somehow?

Downgrading to the the non broken version is possible for me. Did you perhaps forget to run pnpm install (or your package managers equivalent) after reverting the commit?

Nope, I'm even running rm -rf .tanstack node_modules pnpm-lock.yaml and then running pnpm install, still does not work.

That's strange 🤔

[TheDunco]

Can confirm this same issue, downgrading does not solve the issue though. Maybe a critical dependency broke somehow?

Could that be related to the subdependency/peer dependency issue discussed here: #3001? Even though you downgraded could the downgraded package or the @tanstack/start package now be grabbing the latest version of the @tanstack/react-router package as sub/peer deps? Does the 1.129.0 version still show up in a pnpm why @tanstack/react-router?