Skip to content

fix: peer dependencies#3318

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
CarsonF:bugfix/peer-deps
Feb 4, 2025
Merged

fix: peer dependencies#3318
schiller-manuel merged 1 commit into
TanStack:mainfrom
CarsonF:bugfix/peer-deps

Conversation

@CarsonF

@CarsonF CarsonF commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

With these peer dependencies declared, Yarn PnP correctly stores one version of each tanstack package.
Without each one of these additions, yarn will duplicate one or more tanstack packages.
Which leads to context problems like #2540

Comment thread packages/router-plugin/package.json Outdated
@nx-cloud

nx-cloud Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit ff67833f5d597e8d6ffed2d9829b14aa389f11b5.


☁️ Nx Cloud last updated this comment at 2025-02-04 11:38:06 UTC

@nx-cloud

nx-cloud Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit ff67833f5d597e8d6ffed2d9829b14aa389f11b5.


☁️ Nx Cloud last updated this comment at 2025-02-03 22:00:26 UTC

@pkg-pr-new

pkg-pr-new Bot commented Feb 3, 2025

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3318

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3318

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3318

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3318

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3318

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3318

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3318

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3318

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3318

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3318

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3318

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3318

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3318

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3318

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3318

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3318

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3318

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3318

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3318

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3318

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3318

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3318

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3318

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3318

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3318

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3318

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3318

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3318

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3318

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3318

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3318

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3318

commit: ff67833

@CarsonF

CarsonF commented Feb 4, 2025

Copy link
Copy Markdown
Contributor Author

@schiller-manuel That PR test failure isn't related to my change right?

@schiller-manuel

Copy link
Copy Markdown
Collaborator

no this is not related, CI was somehow broken. fixed that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants