Skip to content

fix: vite peer dependencies - #3406

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
CarsonF:peer-deps
Feb 12, 2025
Merged

fix: vite peer dependencies#3406
schiller-manuel merged 1 commit into
TanStack:mainfrom
CarsonF:peer-deps

Conversation

@CarsonF

@CarsonF CarsonF commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Vite was still be duplicated for me with Yarn PnP. Not a big deal, but indicating something was not entirely accurate.
All of these packages were declaring the react plugin, which would require them to also declare vite as a peer dep.
However, in all of these cases here the plugin was only being used in the vite configs, not being imported into src.
Moving them to dev removes the need to declare the peer dep, and fix the duplication problem by consumers.
I also removed vite from a couple of packages that declared them as a peer dep, which I had added in #3318, since this is the real solution.

@nx-cloud

nx-cloud Bot commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 304e918.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 3m 12s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 17:50:11 UTC

@pkg-pr-new

pkg-pr-new Bot commented Feb 12, 2025

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3406

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3406

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3406

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3406

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3406

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3406

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3406

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3406

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3406

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3406

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3406

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3406

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3406

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3406

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3406

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3406

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3406

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3406

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3406

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3406

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3406

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3406

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3406

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3406

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3406

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3406

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3406

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3406

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3406

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3406

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3406

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3406

commit: 304e918

@schiller-manuel
schiller-manuel merged commit e2069a4 into TanStack:main Feb 12, 2025
@CarsonF
CarsonF deleted the peer-deps branch February 12, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants