Fix invalid plane name - #172
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 72.25% 72.34% +0.09%
==========================================
Files 32 32
Lines 5485 5485
==========================================
+ Hits 3963 3968 +5
+ Misses 1522 1517 -5 ☔ View full report in Codecov by Sentry. |
thierry-martinez
left a comment
There was a problem hiding this comment.
This error should have been caught by an AssertionError or another exception.
| graph.add_nodes_from(nodes) | ||
| graph.add_edges_from(edges) | ||
| meas_planes = {0: "XY", 1: "XY", 2: "ZX", 3: "YZ"} | ||
| meas_planes = {0: "XY", 1: "XY", 2: "XZ", 3: "YZ"} |
There was a problem hiding this comment.
This error should have been caught by an AssertionError or another exception.
There was a problem hiding this comment.
I totally agree. Let's use pydantic.
There was a problem hiding this comment.
Note: data validation to find_gflow and others being added in #155 by @thierry-martinez , based on new data classes
|
closing because this was fixed with added plane validation routine in #155. |
Fix invalid plane index
ZX.