Skip to content

Fix invalid plane name - #172

Closed
EarlMilktea wants to merge 1 commit into
masterfrom
fix-gflowtest
Closed

Fix invalid plane name#172
EarlMilktea wants to merge 1 commit into
masterfrom
fix-gflowtest

Conversation

@EarlMilktea

Copy link
Copy Markdown
Contributor

Fix invalid plane index ZX.

@EarlMilktea EarlMilktea self-assigned this Jun 29, 2024
@codecov

codecov Bot commented Jun 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.34%. Comparing base (cef611d) to head (050907d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   72.25%   72.34%   +0.09%     
==========================================
  Files          32       32              
  Lines        5485     5485              
==========================================
+ Hits         3963     3968       +5     
+ Misses       1522     1517       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thierry-martinez thierry-martinez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error should have been caught by an AssertionError or another exception.

Comment thread tests/test_gflow.py
graph.add_nodes_from(nodes)
graph.add_edges_from(edges)
meas_planes = {0: "XY", 1: "XY", 2: "ZX", 3: "YZ"}
meas_planes = {0: "XY", 1: "XY", 2: "XZ", 3: "YZ"}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error should have been caught by an AssertionError or another exception.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. Let's use pydantic.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: data validation to find_gflow and others being added in #155 by @thierry-martinez , based on new data classes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below by @thierry-martinez
778f709

@shinich1

Copy link
Copy Markdown
Contributor

closing because this was fixed with added plane validation routine in #155.

@shinich1 shinich1 closed this Jul 21, 2024
@EarlMilktea
EarlMilktea deleted the fix-gflowtest branch July 25, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants