Skip to content

Fix invalid plane name #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EarlMilktea wants to merge 1 commit into from
Closed

Fix invalid plane name #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_gflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def _graph5() -> GraphForTest:
graph = nx.Graph()
graph.add_nodes_from(nodes)
graph.add_edges_from(edges)
meas_planes = {0: "XY", 1: "XY", 2: "ZX", 3: "YZ"}
meas_planes = {0: "XY", 1: "XY", 2: "XZ", 3: "YZ"}

@thierry-martinez thierry-martinez Jul 3, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error should have been caught by an AssertionError or another exception.

@EarlMilktea EarlMilktea Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. Let's use pydantic.

@shinich1 shinich1 Jul 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: data validation to find_gflow and others being added in #155 by @thierry-martinez , based on new data classes

@shinich1 shinich1 Jul 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below by @thierry-martinez
778f709

return GraphForTest(
graph,
inputs,
Expand Down