Add bazelisk run //:install#4003
Merged
maliberty merged 6 commits intoMar 21, 2026
Merged
Conversation
bazelisk run //:install Builds and installs OpenROAD (with GUI), Yosys, and yosys-slang to tools/install/. Re-runs are instant (stamp file per submodule commit). No sudo required. On Ubuntu, checks for missing -dev packages before building and fails fast with the apt install command. Other platforms not checked (we can't test them, contributions welcome). Docs updated to present Bazel / Nix / CMake as three equal paths. Zero churn: no changes to DependencyInstaller.sh, flow/, setup.sh, build_openroad.sh, or Nix flakes. Tested: gcd/nangate45 synth, asap7/uart synth (yosys-slang). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
maliberty
requested changes
Mar 17, 2026
| local missing_pkgs=() | ||
|
|
||
| # Commands needed for yosys build | ||
| command -v bison &>/dev/null || { missing_cmds+=(bison); missing_pkgs+=(bison); } |
Member
There was a problem hiding this comment.
Without running the dependency installer there is no guarantee these will be usable versions.
Collaborator
Author
There was a problem hiding this comment.
fixed, scope is now MVP for bazel users to build and debug OpenROAD
Comment on lines
+73
to
+74
| echo "On Ubuntu this would be:" | ||
| echo " sudo apt install ${missing_pkgs[*]}" |
Member
There was a problem hiding this comment.
again no guarantee this is right
Collaborator
Author
There was a problem hiding this comment.
fixed, scope is now MVP for bazel users to build and debug OpenROAD
| # Currently only Ubuntu/Debian is checked. Dependency checking for | ||
| # other platforms (macOS, RHEL, Fedora, etc.) is not implemented | ||
| # because we cannot test them. Contributions welcome. | ||
| check_ubuntu_deps() { |
Member
There was a problem hiding this comment.
What about all the other platforms?
Collaborator
Author
There was a problem hiding this comment.
fixed, scope is now MVP for bazel users to build and debug OpenROAD
| | **CMake** | `sudo ./setup.sh` | Yes | Existing CMake developers | | ||
|
|
||
| Supported configurations are: Ubuntu 20.04, Ubuntu 22.04, Ubuntu 22.04(aarch64), RHEL 8, RockyLinux 9 and Debian 11. | ||
| ### Bazel (recommended) |
Member
There was a problem hiding this comment.
This can't be the recommended method based on what is in this PR currently.
Collaborator
Author
There was a problem hiding this comment.
fixed, scope is now MVP for bazel users to build and debug OpenROAD
Remove Ubuntu dep checking, --skip-openroad flag, and verbose help text. Docs: position Bazel as unsupported developer-only option, CMake first. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Add cross-platform dep checking (Ubuntu, RHEL, macOS, openSUSE). Remove verbose help text. Docs: replace outdated Bazel section with //:install, mark as unsupported developer-only path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
maliberty
reviewed
Mar 18, 2026
Address review feedback: make it clear this is not a general-purpose installer but specifically for bazel-orfs developers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
maliberty
approved these changes
Mar 19, 2026
Collaborator
Author
|
@vvbandeira @maliberty please retrigger, CI outage |
oharboe
added a commit
to oharboe/OpenROAD-flow-scripts
that referenced
this pull request
May 11, 2026
bazel/BUILD only existed to export the bazel-orfs patches I had introduced. Since those patches landed upstream (bazel-orfs PR The-OpenROAD-Project#720) and were removed in the previous commit, the package is no longer needed. Dropping it lets //:install_for_bazel reference bazel/install.sh as a same-package file again, the way it has been on master since PR The-OpenROAD-Project#4003 — so this PR no longer touches that rule. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds and installs OpenROAD (with GUI), Yosys, and yosys-slang to tools/install/. Re-runs are instant (stamp file per submodule commit). No sudo required.
On Ubuntu, checks for missing -dev packages before building and fails fast with the apt install command. Other platforms not checked (we can't test them, contributions welcome).
Docs updated to present Bazel / Nix / CMake as three equal paths.
Zero churn: no changes to DependencyInstaller.sh, flow/, setup.sh, build_openroad.sh, or Nix flakes.
Tested: gcd/nangate45 synth, asap7/uart synth (yosys-slang).