Skip to content

autotuner: pin packages version#720

Merged
vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
vvbandeira:at-fix-packages
Dec 24, 2022
Merged

autotuner: pin packages version#720
vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
vvbandeira:at-fix-packages

Conversation

@vvbandeira
Copy link
Copy Markdown
Member

Recent versions of colorama and bayesian-optimization crash, these versions are known to work without issue.

Signed-off-by: Vitor Bandeira vitor.vbandeira@gmail.com

Recent versions of colorama and bayesian-optimization crash, these
versions are known to work without issue.

Signed-off-by: Vitor Bandeira <vitor.vbandeira@gmail.com>
@vvbandeira
Copy link
Copy Markdown
Member Author

@vvbandeira vvbandeira merged commit 5f70ece into The-OpenROAD-Project:master Dec 24, 2022
@vvbandeira vvbandeira deleted the at-fix-packages branch December 24, 2022 19:16
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request May 11, 2026
…eamed patches

bazel-orfs PR The-OpenROAD-Project/bazel-orfs#720
lands the two patches we were carrying as 0001/0002:

  - orfs_design() accepts config = "config.mk" explicitly and drops
    the blanket native.exports_files(native.glob(["*"]));
  - orfs_design() takes a local_arguments= list to drop config.mk
    helpers (e.g. VERILOG_FILES_BLACKBOX) before orfs_flow().

It also adds parser unit tests covering the VERILOG_FILES_BLACKBOX
pattern that local_arguments= targets.

Bump bazel-orfs to 717655415d (PR The-OpenROAD-Project#720 head) and drop both patches.
bazel/BUILD shrinks to a single exports_files(["install.sh"]) — the
only remaining reason for the package is making //bazel:install.sh
resolvable from //:install_for_bazel.

Verified: bazelisk test //flow/designs/asap7/gcd/... passes;
microwatt and chameleon (both consumers of local_arguments=) parse.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request May 11, 2026
bazel/BUILD only existed to export the bazel-orfs patches I had
introduced.  Since those patches landed upstream (bazel-orfs PR The-OpenROAD-Project#720)
and were removed in the previous commit, the package is no longer
needed.  Dropping it lets //:install_for_bazel reference
bazel/install.sh as a same-package file again, the way it has been
on master since PR The-OpenROAD-Project#4003 — so this PR no longer touches that rule.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant