Dg replace merge by openroad-robot · Pull Request #4959 · The-OpenROAD-Project/OpenROAD

openroad-robot · 2024-04-16T15:30:14Z

Hi Matt,

I added the init codes of DG-RePlAce. Could you please take a look ?

Thanks,
Zhiang

…t-private/master get all the latest commits from the master branch

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 83. Check the log or trigger a new build to see more.

maliberty · 2024-04-16T15:55:00Z

@ZhiangWang033 needs clang-format and clang-tidy cleaned up. Also it needs to gracefully handle not having cuda installed.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 56. Check the log or trigger a new build to see more.

github-actions · 2024-04-16T16:40:37Z

+
+namespace gpl2 {
+
+using namespace std;


warning: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace]

using namespace std; ^

github-actions · 2024-04-16T16:40:37Z

+    : network_(nullptr),
+      db_(nullptr),
+      log_(nullptr),
+      pbVars_(),


warning: initializer for member 'pbVars_' is redundant [readability-redundant-member-init]

Suggested change

pbVars_(),

,

github-actions · 2024-04-16T16:40:38Z

+    else {
+      return original;
+    }


warning: do not use 'else' after 'return' [readability-else-after-return]

Suggested change

else {

return original;

}

return original;

github-actions · 2024-04-16T16:40:38Z

+
+#pragma once
+
+#include <cuda.h>


warning: 'cuda.h' file not found [clang-diagnostic-error]

#include <cuda.h> ^

github-actions · 2024-04-16T16:40:38Z

+  int64_t nesterovInstsArea() const
+  {
+    return stdInstsArea_
+           + static_cast<int64_t>(round(macroInstsArea_ * targetDensity_));


warning: call to 'round' promotes float to double [performance-type-promotion-in-math-fn]

src/gpl2/src/placerBase.h:57:

- #include <memory> + #include <cmath> + #include <memory>

Suggested change

+ static_cast<int64_t>(round(macroInstsArea_ * targetDensity_));

+ static_cast<int64_t>(std::round(macroInstsArea_ * targetDensity_));

github-actions · 2024-04-16T16:40:38Z

+///////////////////////////////////////////////////////////////
+// Instance
+Instance::Instance()
+    : inst_(nullptr),


warning: member initializer for 'inst_' is redundant [modernize-use-default-member-init]

Suggested change

: inst_(nullptr),

: ,

github-actions · 2024-04-16T16:40:38Z

+// Instance
+Instance::Instance()
+    : inst_(nullptr),
+      instId_(-1),


warning: member initializer for 'instId_' is redundant [modernize-use-default-member-init]

Suggested change

instId_(-1),

,

maliberty · 2024-04-16T16:44:28Z

Why are there changes in drt? It seems unrelated. Using std::cout is not ok and would require use of the logger if these are intended.

ZhiangWang033 · 2024-04-17T08:12:59Z

Sorry, my bad. I modified the wrong files when I tested the DR. I will fix this.

…

On Tue, Apr 16, 2024 at 9:44 AM Matt Liberty ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On src/drt/src/gr/FlexGR.cpp <https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*discussion_r1567672245__;Iw!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsgMBP8HVo$> : Why are there changes in drt? It seems unrelated. Using std::cout is not ok and would require use of the logger if these are intended. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*pullrequestreview-2004156145__;Iw!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsg1R-My14$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQR3KJX5STLA3VGXGNOBBZLY5VIQDAVCNFSM6AAAAABGJTAKHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBUGE2TMMJUGU__;!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsgWfV-99U$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rovinski · 2024-04-18T04:05:02Z

Please fix up the copyright organization and year.

maliberty · 2024-05-07T21:46:23Z

@ZhiangWang033 any eta for your updates?

ZhiangWang033 · 2024-05-08T00:41:03Z

Hi Matt, I was busy with ICCAD submission. Will get it done this week. Thanks, Zhiang

…

On Tue, May 7, 2024 at 2:46 PM Matt Liberty ***@***.***> wrote: @ZhiangWang033 <https://urldefense.com/v3/__https://github.com/ZhiangWang033__;!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUu4gn8q4$> any eta for your updates? — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*issuecomment-2099363841__;Iw!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUCz0dueE$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQR3KJTZPF6ZJHP27AYFGITZBFDULAVCNFSM6AAAAABGJTAKHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGM3DGOBUGE__;!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUjCtYlKo$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

…ivate/OpenROAD into dg_replace_merge

This reverts commit 7850f01.

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 33. Check the log or trigger a new build to see more.

github-actions · 2024-07-02T05:13:51Z

+//
+///////////////////////////////////////////////////////////////////////////////
+
+#include "gpl2/MakeGpuReplace.h"


warning: 'gpl2/MakeGpuReplace.h' file not found [clang-diagnostic-error]

#include "gpl2/MakeGpuReplace.h" ^

github-actions · 2024-07-02T05:13:51Z

+//
+///////////////////////////////////////////////////////////////////////////////
+
+#include "gpl2/GpuReplace.h"


warning: 'gpl2/GpuReplace.h' file not found [clang-diagnostic-error]

#include "gpl2/GpuReplace.h" ^

github-actions · 2024-07-02T05:13:51Z

+      dDx_(0.0),
+      dDy_(0.0),
+      densityScale_(0.0),
+      haloWidth_(0),


warning: member initializer for 'haloWidth_' is redundant [modernize-use-default-member-init]

Suggested change

haloWidth_(0),

,

github-actions · 2024-07-02T05:13:51Z

+      densityScale_(0.0),
+      haloWidth_(0),
+      type_(InstanceType::FILLER),
+      isFixed_(false)


warning: member initializer for 'isFixed_' is redundant [modernize-use-default-member-init]

Suggested change

isFixed_(false)

github-actions · 2024-07-02T05:13:51Z

+  int lx = 0.0;
+  int ly = 0.0;
+  inst->getLocation(lx, ly);
+  int ux = lx + floor(bbox->getDX() / 2) * 2;


warning: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division]

int ux = lx + floor(bbox->getDX() / 2) * 2; ^

github-actions · 2024-07-02T05:13:52Z

+{
+  int x;
+  int y;
+  __host__ __device__ IntPoint() : x(0), y(0) {}


warning: declaration uses identifier 'device', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change

__host__ __device__ IntPoint() : x(0), y(0) {}

__host__ _device_ IntPoint() : x(0), y(0) {}

github-actions · 2024-07-02T05:13:52Z

+{
+  float x;
+  float y;
+  __host__ __device__ FloatPoint() : x(0), y(0) {}


warning: declaration uses identifier 'device', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change

__host__ __device__ FloatPoint() : x(0), y(0) {}

__host__ _device_ FloatPoint() : x(0), y(0) {}

github-actions · 2024-07-02T05:13:52Z

+{
+  int64_t x;
+  int64_t y;
+  __host__ __device__ Int64Point() : x(0), y(0) {}


warning: declaration uses identifier 'device', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change

__host__ __device__ Int64Point() : x(0), y(0) {}

__host__ _device_ Int64Point() : x(0), y(0) {}

github-actions · 2024-07-02T05:13:53Z

+
+struct IntRect
+{
+  __host__ __device__ IntRect()


warning: declaration uses identifier 'device', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change

__host__ __device__ IntRect()

__host__ _device_ IntRect()

github-actions · 2024-07-02T05:13:53Z

+
+// numeric operators
+
+__host__ __device__ int fastModulo(const int input, const int ceil);


warning: declaration uses identifier 'device', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change

__host__ __device__ int fastModulo(const int input, const int ceil);

__host__ _device_ int fastModulo(const int input, const int ceil);

ZhiangWang033 and others added 6 commits April 9, 2024 15:58

Merge pull request The-OpenROAD-Project#2033 from The-OpenROAD-Projec…

6dae092

…t-private/master get all the latest commits from the master branch

fix wirelength, poissionSolver

8ed1a43

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

before fix util

a168c1a

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

add init push for DG-RePlAce

edf067b

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

add fix to hier-rtlmp

c154a10

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

fix init and remove readme

b8638fd

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

github-actions Bot reviewed Apr 16, 2024

View reviewed changes

gpl2: clang-format

18618c5

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

maliberty reviewed Apr 16, 2024

View reviewed changes

Comment thread src/gpl2/CMakeLists.txt Outdated

github-actions Bot reviewed Apr 16, 2024

View reviewed changes

maliberty reviewed Apr 16, 2024

View reviewed changes

ZhiangWang033 and others added 6 commits May 12, 2024 15:04

fix std::cout in drt

7850f01

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

Merge branch 'dg_replace_merge' of github.com:The-OpenROAD-Project-pr…

01c2d31

…ivate/OpenROAD into dg_replace_merge

Revert "fix std::cout in drt"

a4a0437

This reverts commit 7850f01.

fixed the license issue

1b9222e

Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>

Merge branch 'master' into dg_replace_merge

617b537

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

mpl2: rename instNet to InstNet

240076a

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

github-actions Bot reviewed Jul 2, 2024

View reviewed changes

kamilrakoczy mentioned this pull request Jul 8, 2024

Convert DG-RePlAce algorithm to Kokkos #5352

Open

maliberty closed this Aug 15, 2024

	+ static_cast<int64_t>(round(macroInstsArea_ * targetDensity_));
	+ static_cast<int64_t>(std::round(macroInstsArea_ * targetDensity_));

	__host__ __device__ IntPoint() : x(0), y(0) {}
	__host__ _device_ IntPoint() : x(0), y(0) {}

	__host__ __device__ FloatPoint() : x(0), y(0) {}
	__host__ _device_ FloatPoint() : x(0), y(0) {}

	__host__ __device__ Int64Point() : x(0), y(0) {}
	__host__ _device_ Int64Point() : x(0), y(0) {}


		// numeric operators

		__host__ __device__ int fastModulo(const int input, const int ceil);

	__host__ __device__ int fastModulo(const int input, const int ceil);
	__host__ _device_ int fastModulo(const int input, const int ceil);

Conversation

openroad-robot commented Apr 16, 2024

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maliberty commented Apr 16, 2024

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

maliberty Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

ZhiangWang033 commented Apr 17, 2024 via email

Uh oh!

rovinski commented Apr 18, 2024

Uh oh!

maliberty commented May 7, 2024

Uh oh!

ZhiangWang033 commented May 8, 2024 via email

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 2, 2024

Choose a reason for hiding this comment