Description field of badges should be bytes not bytes32- front end

[joelamouche]

Should be retrocompatible with bytes32 descriptions (write and read hooks)

Comes after #154

[V-Vaal]

Thanks for opening this issue 👍
Here's an implementation plan I'm proposing for frontend retrocompat between the V1 (bytes32) and V2 (bytes) badge registry contracts.

---

Approach

Read path (version-aware)

• Introduce a dedicated hook: useBadgeRegistryVersion(address)
• Detect the deployed contract version once, based on:
  • totalBadges()
  • and a safe getBadgeAt(0) probe using the V2 ABI
• Decode strictly based on the detected version:
  • V1 → bytes32ToString
  • V2 → bytesToString
• No heuristics (no length checks, no guessing)

Write path (robust fallback)

• Always try V2 first: createBadge(bytes32, bytes)
• If it reverts, fallback to V1: createBadge(bytes32, bytes32)
• No dependency on version detection for writes (simpler & more robust)

Implementation plan

1. Shared utils

Add stringToBytes() in blockchainUtils.ts for string → bytes conversion.

2. Split ABIs (avoid viem/wagmi ambiguity)

Replace the single ABI with:

• badgeRegistryAbiV1 (bytes32 description)
• badgeRegistryAbiV2 (bytes description)

No duplicated signatures in the same ABI.

3. Version detection hook

Create:

useBadgeRegistryVersion(address?: `0x${string}`)

Behavior:

• No early return before hooks (React rules respected)
• enabled: Boolean(address) on all reads
• Reset version when address changes

Detection logic:

• count === 0 → assume V2
• V2 getBadgeAt(0) succeeds → V2
• V2 getBadgeAt(0) reverts → V1
• versionTestQuery.error is treated as a signal, not a fatal error

Returns:

{ version: "v1" | "v2" | null, isLoading, error }

4. Reading badges

Update use-get-badges.ts:

• Use useBadgeRegistryVersion(address)
• Select ABI based on version
• Decode strictly according to version
• refetch() remains coherent with address + version

5. Creating badges

Update use-create-badge.ts:

• No version hook dependency
• Always:

1. Try V2 (bytes)
2. Fallback to V1 (bytes32)

• Simple, robust, RPC-safe

6. Cleanup

Refactor use-create-attestation.ts to reuse shared utils (stringToBytes, stringToBytes32).

Summary

• Safe across redeployments and environments
• Easy to remove once V1 is fully deprecated

---

Happy to implement this unless you’d prefer a different direction or scope.

[joelamouche]

@V-Vaal feel free to share your twitter/bsky handles (in disc dm) if you want me to advertise your work

[V-Vaal]

Thanks @joelamouche, much appreciated ! I'll DM you on Discord.