Debug VC6 build crashes

[helmutbuhler]

The debug VC6 build is broken in main. It crashes after the intro when started without -quickstart.
Here is the crash:

Here is the callstack:

Note that TerrainDecalTextureName in the callstack is not a function. There is some stack corruption going on.

PR #1035 doesn't crash. The bug must have gotten introduced sometime since then.

[xezon]

I can try look into that if no one beats me to it.

[helmutbuhler]

I can try look into that if no one beats me to it.

Yes please. I didn't have time yet to investigate this further than what I described here.

[Mauller]

i was going to have a quick look to see if i could track down the last good build, but i can't even run the debug builds locally lol.

[helmutbuhler]

i was going to have a quick look to see if i could track down the last good build, but i can't even run the debug builds locally lol.

Try putting these dlls in the path with the exe:
MSVCIRTD.zip

The debug dlls are not distributed with Windows, they only come with VC6.

[xezon]

The stack is currupted

 	generalszh.exe!AsciiString::validate()  Line 100	
>	generalszh.exe!ModelConditionInfo::validateWeaponBarrelInfo()  Line 752 + 0xb bytes	
 	generalszh.exe!W3DModelDrawModuleData::validateStuffForTimeAndWeather()  Line 1080 + 0x76 bytes	
 	generalszh.exe!W3DModelDraw::W3DModelDraw()  Line 1747	
 	generalszh.exe!W3DTankDraw::W3DTankDraw()  Line 89 + 0x2f bytes	
 	generalszh.exe!W3DTankDraw::friend_newModuleInstance()  Line 64 + 0x15e bytes	
 	generalszh.exe!ModuleFactory::newModule()  Line 640 + 0x12 bytes	
 	generalszh.exe!Drawable::Drawable()  Line 464 + 0x26 bytes	
 	generalszh.exe!W3DGameClient::friend_createDrawable()  Line 130	
 	generalszh.exe!ThingFactory::newDrawable()  Line 354 + 0x12 bytes	
 	generalszh.exe!GameLogic::sendObjectCreated()  Line 4214 + 0x1b bytes	
 	generalszh.exe!Object::initObject()  Line 531	
 	generalszh.exe!ThingFactory::newObject()  Line 344	
 	generalszh.exe!GameLogic::startNewGame()  Line 1926 + 0x1e bytes	
 	generalszh.exe!MemoryPoolFactory::adjustTotals()  Line 2821 + 0x19 bytes	
 	generalszh.exe!MemoryPool::freeBlock()  Line 1753	
 	d3d8.dll!552e85fc() 	
 	[Frames below may be incorrect and/or missing, no symbols loaded for d3d8.dll]	
 	d3d8.dll!552fa314() 	
 	KernelBase.dll!765eb552() 	
 	KernelBase.dll!765b54c6() 	
 	msvcrt.dll!75eaeb84() 	
 	generalszh.exe!RenderObjClass::Get_Position()  Line 505	
 	generalszh.exe!W3DView::screenToWorldAtZ()  Line 3313	
 	generalszh.exe!View::getScreenCornerWorldPointsAtZ()  Line 253 + 0x11 bytes	
 	generalszh.exe!W3DView::getAxisAlignedViewRegion()  Line 1408	
 	generalszh.exe!WindowVideoManager::update()  Line 197	
 	generalszh.exe!SelectionTranslator::translateGameMessage()  Line 376 + 0x19 bytes	
 	generalszh.exe!GameEngine::update()  Line 761	
 	generalszh.exe!GameEngine::execute()  Line 819	
 	generalszh.exe!GameMain()  Line 56	
 	generalszh.exe!_WinMain@16()  Line 898	
 	generalszh.exe!_WinMainCRTStartup()  + 0x134 bytes	
 	kernel32.dll!756cfcc9() 	
 	ntdll.dll!778782ae() 	
 	ntdll.dll!7787827e() 	
 	generalszh.exe!MapCache::loadUserMaps()  Line 616 + 0x90 bytes	

[xezon]

Debug build runs when turning off all debug logging.

[xezon]

No Asan hit in VS2022 RTS_DEBUG build to Shell Map

[xezon]

getW3DModelDrawModuleData() in W3DModelDraw::W3DModelDraw is 0

[xezon]

Callstack in with No Optimization:

 	0000b216()	
>	generalszh.exe!ModuleFactory::newModule()  Line 640 + 0xf bytes	C++
 	generalszh.exe!Drawable::Drawable()  Line 464 + 0x36 bytes	C++
 	generalszh.exe!W3DGameClient::friend_createDrawable()  Line 126 + 0x34 bytes	C++
 	generalszh.exe!ThingFactory::newDrawable()  Line 354 + 0x1a bytes	C++
 	generalszh.exe!GameLogic::sendObjectCreated()  Line 4205 + 0x16 bytes	C++
 	generalszh.exe!Object::initObject()  Line 531	C++
 	generalszh.exe!ThingFactory::newObject()  Line 344	C++
 	generalszh.exe!GameLogic::startNewGame()  Line 1916 + 0x26 bytes	C++
 	generalszh.exe!GameLogic::update()  Line 3656	C++
 	generalszh.exe!SubsystemInterface::UPDATE()  Line 73 + 0xd bytes	C++
 	generalszh.exe!GameEngine::update()  Line 767	C++
 	generalszh.exe!Win32GameEngine::update()  Line 93	C++
 	generalszh.exe!GameEngine::execute()  Line 823 + 0xd bytes	C++
 	generalszh.exe!GameMain()  Line 52 + 0x12 bytes	C++
 	generalszh.exe!WinMain()  Line 887 + 0x5 bytes	C++
 	generalszh.exe!WinMainCRTStartup()  Line 330 + 0x36 bytes	C
 	kernel32.dll!756cfcc9() 	
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	
 	ntdll.dll!778782ae() 	
 	ntdll.dll!7787827e() 	
 	generalszh.exe!GameWindowTransitionsHandler::GameWindowTransitionsHandler()  Line 365 + 0x6e bytes	C++

ASSERTION FAILURE: *** ASSET ERROR: public bone 'turret' (and variations thereof) not found in model avlasertnk_d1!

Stack Dump:
[Ignore]
First-chance exception at 0x0000b216 in generalszh.exe: 0xC0000005: Access violation.